fix(data): strip Rules CSV BOM + clear 10 EN role-term garbles -> smooth talker - #330
Merged
Merged
Conversation
clusterManager-Myia
left a comment
clusterManager-Myia
left a comment
Collaborator
There was a problem hiding this comment.
APPROVED — fix(csv): normalize residual EN garbles
What it does
Replaces residual garbled EN translations with correct terms in 2 CSV files:
- Rules CSV: "peacher" → "smooth talker" (5 occurrences)
- Scenarii CSV: "peacher" → "smooth talker" (5 occurrences)
"Smooth talker" is the correct translation of the French "baratineur" in the game context.
Concerns
None. Text-only change, no logic modification. Merge state dirty — likely a rebase is needed.
Same-owner → COMMENT event.
…oth talker Surgical fix-forward on real master b560552 (prior PR #330 branch was built on a stale local base; rebased here). - Cards/Rules CSV: strip UTF-8 BOM (EF BB BF) that breaks CsvHelper header mapping (pk -> pk -> 0 records). - 10 EN-column garbles -> "smooth talker" (residue #320/#321 missed: doubled-syllable corruptions baratinerer/baratinener/barater + peacher): Rules Text_en: lines 524 (peacher), 737 (baratinerer). Scenarii context_en: senator, gladiator, employee, 5G, journalist, alliance, loyalty, old-friend (8 cells). Full unique English phrases used so PT cells (po-2023 scope: Rules 283, Scenarii Tom Thumb) are untouched. No BOM written back, LF preserved, balanced 11/11 diff. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
jsboige
force-pushed
the
fix/csv-en-garbles-smooth-talker
branch
from
May 22, 2026 10:57
8a4f0bd to
5985436
Compare
jsboige
changed the title
clusterManager-Myia
left a comment
clusterManager-Myia
left a comment
Collaborator
There was a problem hiding this comment.
APPROVED — strip BOM + clear EN garbles
Updated HEAD: BOM strip + more garble fixes. Text-only. Same-owner → COMMENT.
3 tasks
jsboige
added a commit
that referenced
this pull request
May 23, 2026
#338 added a UTF-8 BOM (ef bb bf) to the Scenarii CSV header; master has none (#330 deliberately stripped the Rules BOM for the same reason). The BOM corrupts the first CsvHelper column name (path). Only the 3 leading bytes are removed; PT translation content unchanged. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope (ai-01) — fix-forward chirurgical, base master reelle
b5605524Ce que fait cette PR
Cards/Rules/Argumentum Rules - Cards.csvEF BB BF-> l'en-tetepkdevientpk!=pk-> CsvHelper charge 0 records.pk,Text,...(verifiexxd).smooth talker(residus que fix(rules): correct EN/PT contamination in Rules translations #320/fix(scenarii): correct PT contamination — replace FR role terms #321 n'avaient pas attrapes : corruptions a syllabe doubleebaratinerer/baratinener/barater+peacher) :Text_en: ligne 524 (peacher), ligne 737 (baratinerer).context_en(8 cellules) : senateur, gladiateur, employe, 5G, journaliste, alliance, fidelite, vieil-ami.Hors scope (po-2023, cell-by-cell re-run verifie)
o baratinener), Scenarii Tom Thumb (o barater comeu) -> terme PT canonique (O Embromador).By comming by the neighbor's left,this is a choice for my kittens,Saynet->saynete, etc.Garanties chirurgicales
barater) ne sont jamais touchees.Gate
Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com