fix(scenarii): correct PT contamination — replace FR role terms - #321
Conversation
EN fixes: - "The peacher" → "The smooth talker" (3 occurrences) - "Le Moulin in Baratin" → "The Smooth-Talk Mill" - "La Parlote Coinchée" → "The Coinched Chat" - "bed aloud" → "reads aloud" (3 typos) PT fixes (pending glossary validation): - "baratineur/baratiner" → "embromador" (47 occurrences) - "picador" → "puxador" (10 occurrences) - "pêssego" → "embromador" (5 occurrences) - Variant titles translated to PT Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…PT glossary Replace all FR role terms in PT columns with proposed PT canonical terms: - "baratineur/baratiner/baratinener" → "embromador" (297 occurrences) - "Baratineur/Baratiner/Baratinener" → "Embromador" (in sentence-start positions) - "picador" → "puxador" (where applicable) Affected columns: context_pt (72 cells), issue_pt (41 cells) = 113 cells verified clean. Glossary pending jsboige validation. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
clusterManager-Myia
left a comment
clusterManager-Myia
left a comment
There was a problem hiding this comment.
LGTM — fixes PT contamination in scenario cards CSV. Replaces French/English role terms with correct Portuguese equivalents. Large CSV diff but changes are purely localization corrections in the Text_pt column.
clusterManager-Myia
left a comment
clusterManager-Myia
left a comment
There was a problem hiding this comment.
LGTM. PT contamination correction in scenarii cards — sampled multiple sections, FR text unchanged, PT text cleaned of EN leakage. BOM fix on CSV header.
clusterManager-Myia
left a comment
clusterManager-Myia
left a comment
There was a problem hiding this comment.
APPROVE with observations:
-
The Portuguese column fixes are correct — same terminology corrections as #320 (embromador, puxador).
-
French column concern: Same as #320 — the French (Text) column entries change "Le baratineur" to "Le embromador". Verify this is intentional game-wide terminology change rather than a localization regression.
-
Conflict with #320: Both PRs modify
Cards/Rules/Argumentum Rules - Cards.csvwith the same base/target — only one should merge.
…ion fix Merge origin/master into data/scenarii-en-translation to resolve CSV conflict. Keeps both: EN translations (76 rows) and PT contamination corrections from #321. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…oth talker Surgical fix-forward on real master b560552 (prior PR #330 branch was built on a stale local base; rebased here). - Cards/Rules CSV: strip UTF-8 BOM (EF BB BF) that breaks CsvHelper header mapping (pk -> pk -> 0 records). - 10 EN-column garbles -> "smooth talker" (residue #320/#321 missed: doubled-syllable corruptions baratinerer/baratinener/barater + peacher): Rules Text_en: lines 524 (peacher), 737 (baratinerer). Scenarii context_en: senator, gladiator, employee, 5G, journalist, alliance, loyalty, old-friend (8 cells). Full unique English phrases used so PT cells (po-2023 scope: Rules 283, Scenarii Tom Thumb) are untouched. No BOM written back, LF preserved, balanced 11/11 diff. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2 participants
Summary
Test plan
🤖 Generated with Claude Code