Skip to content

fix(csv): expand desc_en for 2 additional Fallacies (#202 phase 1b) - #213

Merged
jsboige merged 1 commit into
masterfrom
fix/epic-202-csv-text-fixes-phase1b
Apr 22, 2026
Merged

fix(csv): expand desc_en for 2 additional Fallacies (#202 phase 1b)#213
jsboige merged 1 commit into
masterfrom
fix/epic-202-csv-text-fixes-phase1b

Conversation

@jsboige

@jsboige jsboige commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Additional Phase 2 audit (2026-04-22) surfaced 2 desc_en gaps not covered by PR #203. Both concern Fallacies where the English description was 37-39 characters while the French source was 101-107 characters — same pattern as the 4 gaps already fixed in #203.

Changes

PK Fallacy FR length EN before EN after
514 Respiration paralinguistique 107c 39c (Breathing in ways that convey messages.) 86c (You seek to convey certain intentions through the act of audible and marked breathing.)
838 Distinction sans différence 101c 37c (Distinguishing two of the same thing.) 98c (You distinguish between two elements that are, in fact, similar or have no significant difference.)

Method

Same surgical approach as PR #203:

  • Targeted string replacement with uniqueness assertion (both target strings were unique in the CSV)
  • PK 838 new value quoted (contains commas)
  • Post-edit CSV parser verification: 1408 rows parse correctly (unchanged)

Test plan

  • CSV parses to 1408 rows (no structural damage)
  • Only 2 cells changed (diff stat: 1 file changed, 2 insertions(+), 2 deletions(-))
  • Cards/Fallacies/Argumentum Fallacies - Taxonomy.csv — single file touched
  • Manual read-through of new EN text for naturalness (recommended reviewer: PT/EN speaker)

Why separate PR from #203

PR #203 is already reviewed and approved by po-2023. Adding scope would invalidate the review. This follow-up is small (2 cells) and cleanly scoped to allow independent merge.

Relationship to Epic #202

Epic #202 Phase 1 focused on Fallacies desc_en gaps. PR #203 fixed 4 (PK 142, 225, 326, 327, 549, 856 + link/typo fixes). This PR closes the remaining 2 (PK 514, 838) discovered on deeper audit.

Remaining Phase 2 work documented in #211 (PT Rules retranslation, blocked by #183/PR #210).

🤖 Generated with Claude Code

Two additional desc_en gaps found during Phase 2 audit (2026-04-22),
not covered by PR #203. Both translations were too concise vs the
richer French source descriptions.

- PK 514 (Respiration paralinguistique): 39 -> 86 chars
  Was: "Breathing in ways that convey messages."
  Now: "You seek to convey certain intentions through the act
       of audible and marked breathing."

- PK 838 (Distinction sans différence): 37 -> 98 chars
  Was: "Distinguishing two of the same thing."
  Now: "You distinguish between two elements that are, in fact,
       similar or have no significant difference."

Surgical changes only (2 cells). CSV parses correctly (1408 rows).
Value containing commas for PK 838 properly quoted.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@jsboige
jsboige merged commit 4ef296f into master Apr 22, 2026
1 check passed
@jsboige
jsboige deleted the fix/epic-202-csv-text-fixes-phase1b branch April 22, 2026 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant