CANManager, Mount, OpticalFlow, Proximity, SerialManager: alphabetise protocol and type param values #29075
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a small improvement in user usability by alphabetising the _PROTOCOL and _TYPE values displayed to users in GCS drop-downs. This does not affect the order displayed in the wiki pages
This change has been tested by running, "./Tools/autotest/autotest.py build.Copter test.Copter.Parameters" and reviewing the output of the "buildlogs/apm.pdef.xml" file before and after.
The only downside of this change is perhaps that sometimes the most common items are no longer near the top. So for example, with the SERIALx_PROTOCOL parameter, MAVLink2 is in the middle instead of at the top. If we think this is an issue then I'm happy to manually resort them. Personally I think the purely alphabetical order is fine but I don't feel strongly about it
Below are the changes found:
CAN_D1_PROTOCOL, CAN_D2_PROTOCOL
CAN_D1_PROTOCOL2, CAN_D3_PROTOCOL
FLOW_TYPE
MNT1_TYPE, MNT2_TYPE
PRX1_TYPE, PRX2_TYPE, PRX3_TYPE, PRX4_TYPE
CAN_D1_UC_S1_PRO, CAN_D1_UC_S2_PRO, CAN_D1_UC_S3_PRO, CAN_D2_UC_S1_PRO, CAN_D2_UC_S2_PRO, CAN_D2_UC_S3_PRO, CAN_D3_UC_S1_PRO, CAN_D3_UC_S2_PRO, CAN_D3_UC_S3_PRO, NET_P1_PROTOCOL, NET_P2_PROTOCOL, NET_P3_PROTOCOL, NET_P4_PROTOCOL, SCR_SDEV1_PROTO, SCR_SDEV2_PROTO, SCR_SDEV3_PROTO, SERIAL1_PROTOCOL, SERIAL1_PROTOCOL, SERIAL2_PROTOCOL, SERIAL3_PROTOCOL, SERIAL4_PROTOCOL, SERIAL5_PROTOCOL, SERIAL6_PROTOCOL, SERIAL7_PROTOCOL, SERIAL8_PROTOCOL, SERIAL9_PROTOCOL
Note: the parameter sorting feature doesn't appear to work with GPS1_TYPE and GPS2_TYPE so I've removed that change from the PR