Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rover: Integration of rover quick tune feature #29032

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bijuthaj
Copy link

@bijuthaj bijuthaj commented Jan 9, 2025

Purpose

The changes include the integration of quick tune feature for rover. The implementation is based on the LUA script of same feature here
https://github.com/ArduPilot/ardupilot/blob/master/libraries/AP_Scripting/applets/rover-quicktune.lua

Approach

The user can perform the quick tune from the circle mode same as that of the LUA script. RCx_OPTION 181(Quick Tune) can be configured to trigger the tuning from the CIRCLE mode. Please refer the read me of the LUA script implementation https://github.com/ArduPilot/ardupilot/blob/master/libraries/AP_Scripting/applets/rover-quicktune.md

Testing performed

rover_before_tuning
Before tuning

rover_after_tuning
After tuning

rover_after_tuning_console

rtun_params

@bijuthaj bijuthaj force-pushed the pr-rover-quicktune branch 2 times, most recently from 4eb74ba to 60da389 Compare January 10, 2025 04:46
The changes include the integration of quick tune feature for rover. The implementation is based on the LUA
script of same feature here
https://github.com/ArduPilot/ardupilot/blob/master/libraries/AP_Scripting/applets/rover-quicktune.lua
@george-hawkins
Copy link

Wow - this looks impressive.

Is there any data to confirm that it produces the same results as the original Lua script (given the same inputs)?

If this works as expected, it's a great addition to the Rover codebase, allowing users of cheaper FCs to auto-tune their builds.

I hope @rmackay9 or others will have the time needed to take it up and get it merged 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants