-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Update workflows to use Python 3.11 #1949
Conversation
I wanted to PR a change from 3.9 -> 3.10 a month ago, but 3.11 was on the horizon. Now we are still waiting on OoT :/ The frozen version differs between 3.8/3.9 and 3.10/3.11 significantly, so maybe in addition to your changes, we should build 3.8 + 3.11 on the same platform? Probably windows since that gives a "windows7" 7z and another "window10" 7z. |
So end up with the Linux build on 3.11, a windows build on 3.8 (for Win 7), and a windows build on 3.11 (for everyone else)? |
I think with the witness fix and the OoT fix this could be merged now, but we don't have windows+py3.11 builds in the build action - do you want to tackle that? maybe it's time to simplify the build process by moving it to a "sub action" ? Touching github action always takes at least an hour that's why i never cleaned up that mess :D |
Sorry, got side tracked last week so I haven't had a chance to look at this. I'll admit I have barely any experience with GitHub actions, but I'll see what I can do after I go through a wave of PR reviews. |
Actually, maybe it'd be better to make it a separate PR so I can spend the time working on it and we can get the testing workflows at least going. |
Co-authored-by: black-sliver <[email protected]>
Co-authored-by: black-sliver <[email protected]>
Co-authored-by: black-sliver <[email protected]>
What is this fixing or adding?
Title. Confirmed it built using Ubuntu action, but will need @black-sliver to verify for Linux test/build actions. This will be needed as it's expected for AP 0.4.2 to be built on 3.11.
This should be the next stage since AP works on 3.11 as of #1821, so after this workflow update, wait for #1948 and #1933 to be merged, release one final Windows 7 supported release, then drop 3.8 and 3.9 workflows (and Windows 7 support).
How was this tested?
Ran build action on repo fork and it built successfully. Ran 3.11 unit tests locally and passed.
If this makes graphical changes, please attach screenshots.
N/A