Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update workflows to use Python 3.11 #1949

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

ThePhar
Copy link
Member

@ThePhar ThePhar commented Jul 6, 2023

What is this fixing or adding?

Title. Confirmed it built using Ubuntu action, but will need @black-sliver to verify for Linux test/build actions. This will be needed as it's expected for AP 0.4.2 to be built on 3.11.

This should be the next stage since AP works on 3.11 as of #1821, so after this workflow update, wait for #1948 and #1933 to be merged, release one final Windows 7 supported release, then drop 3.8 and 3.9 workflows (and Windows 7 support).

How was this tested?

Ran build action on repo fork and it built successfully. Ran 3.11 unit tests locally and passed.

If this makes graphical changes, please attach screenshots.

N/A

@ThePhar ThePhar added the is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. label Jul 6, 2023
@ThePhar ThePhar requested a review from black-sliver July 6, 2023 02:39
@ThePhar ThePhar added the affects: release/blocker Issues/PRs that must be addressed before next official release. label Jul 6, 2023
@black-sliver
Copy link
Member

I wanted to PR a change from 3.9 -> 3.10 a month ago, but 3.11 was on the horizon. Now we are still waiting on OoT :/

The frozen version differs between 3.8/3.9 and 3.10/3.11 significantly, so maybe in addition to your changes, we should build 3.8 + 3.11 on the same platform? Probably windows since that gives a "windows7" 7z and another "window10" 7z.

@ThePhar
Copy link
Member Author

ThePhar commented Jul 6, 2023

I wanted to PR a change from 3.9 -> 3.10 a month ago, but 3.11 was on the horizon. Now we are still waiting on OoT :/

The frozen version differs between 3.8/3.9 and 3.10/3.11 significantly, so maybe in addition to your changes, we should build 3.8 + 3.11 on the same platform? Probably windows since that gives a "windows7" 7z and another "window10" 7z.

So end up with the Linux build on 3.11, a windows build on 3.8 (for Win 7), and a windows build on 3.11 (for everyone else)?

@black-sliver
Copy link
Member

I think with the witness fix and the OoT fix this could be merged now, but we don't have windows+py3.11 builds in the build action - do you want to tackle that? maybe it's time to simplify the build process by moving it to a "sub action" ? Touching github action always takes at least an hour that's why i never cleaned up that mess :D

@ThePhar
Copy link
Member Author

ThePhar commented Jul 19, 2023

I think with the witness fix and the OoT fix this could be merged now, but we don't have windows+py3.11 builds in the build action - do you want to tackle that? maybe it's time to simplify the build process by moving it to a "sub action" ? Touching github action always takes at least an hour that's why i never cleaned up that mess :D

Sorry, got side tracked last week so I haven't had a chance to look at this. I'll admit I have barely any experience with GitHub actions, but I'll see what I can do after I go through a wave of PR reviews.

@ThePhar
Copy link
Member Author

ThePhar commented Jul 19, 2023

Actually, maybe it'd be better to make it a separate PR so I can spend the time working on it and we can get the testing workflows at least going.

@ThePhar ThePhar merged commit fa3d69c into ArchipelagoMW:main Jul 24, 2023
@ThePhar ThePhar deleted the 311-workflows branch July 24, 2023 01:15
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
kl3cks7r pushed a commit to kl3cks7r/Archipelago that referenced this pull request Dec 15, 2023
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: release/blocker Issues/PRs that must be addressed before next official release. is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants