CI: Drop 3.8 and 3.9 workflows #1822
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThePhar
added
is: refactor/cleanup
ThePhar
added
is: maintenance
|
This should be broken up into 2 different stages. Add 3.11 workflow first since next AP release is 3.11 so we should be checking for that now. Then after we drop win 7 support, remove 3.8 and 3.9 workflows. I've done the first part in #1949 and outlined plan there. Going to leave this PR open for removing 3.8 and 3.9 workflows once we get to that stage. |
ThePhar
changed the title
# Conflicts: # .github/workflows/unittests.yml
alwaysintreble
changed the title
|
Not sure if we want 3.10 windows and macos workflows, but as there aren't any currently didn't add any, and don't think we have much reason to since all distributed builds will be on 3.11 anyways? |
PoryGone
added
the
waiting-on: other
BadMagic100
added
waiting-on: peer-review
|
I think having builds for all supported versions across all OSs would be ideal until/unless the available CI hours for the org run out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Drops 3.8 and 3.9 support and adds 3.11 support in unit tests. We need per-game datapackage and #1821 before this gets merged but there shouldn't be any conflicts.
How was this tested?
The power of tests