OoT: Python 3.11 Compatibility fix and Minor Bug fixes #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThePhar
added
the
is: bug/fix
| @@ -769,7 +769,7 @@ def patch_instrument(rom, ootworld, symbols): | |||
|
|
|||
| def patch_cosmetics(ootworld, rom): | |||
| # Use the world's slot seed for cosmetics | |||
| random.seed(ootworld.multiworld.per_slot_randoms[ootworld.player]) | |||
| random.seed(ootworld.multiworld.per_slot_randoms[ootworld.player].random()) | |||
There was a problem hiding this comment.
Suggested change
| random.seed(ootworld.multiworld.per_slot_randoms[ootworld.player].random()) | |
| random.seed(ootworld.random.random()) |
per_slot_randoms is deprecated now
There was a problem hiding this comment.
but does at least work for now, but I agree, this should be updated.
ThePhar
added
the
affects: release/blocker
ThePhar
changed the title
Berserker66
approved these changes
Jul 9, 2023
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
…#1948) * OoT: biggoron's sword and giant's knife now considered progression in non-glitchless * OoT: fixed seeding the random module with the Random object
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
…#1948) * OoT: biggoron's sword and giant's knife now considered progression in non-glitchless * OoT: fixed seeding the random module with the Random object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfixes:
Note: I am aware that oot is using random, which will almost certainly cause nondeterministic behavior in cosmetic randomization with multiple seeds. Since it's just cosmetics and that can be fixed in the adjuster, I'm ok with just letting that happen. Modification to avoid this is highly invasive and would make future updating more difficult.