Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/customized webpack plugin integration #2

Merged
merged 1,131 commits into from
Apr 10, 2020

Conversation

ArbaazDossani
Copy link
Owner

No description provided.

heyimalex and others added 30 commits July 18, 2019 14:46
* Attempt at fixing CI issue on windows

* Try to debug why verdaccio isn't in the ps output

* Just remove the kill call alltogether
This closes facebook#7359 by making IMAGE_INLINE_SIZE_LIMIT=0 actually disable image inlining.

We use url-loader's `limit` option to set the line at which images will be inlined, and we basically expose this option to our end users via the IMAGE_INLINE_SIZE_LIMIT environment variable. Most people using it want to disable inlining images all together (the major motivator for adding it at all was I think for strict CSP), and our documentation said setting the value to zero would do that. However, it did the opposite: url-loader treated zero as "no limit".

The update to 2.x fixes this; zero means nothing gets inlined. The other changes from the version bump shouldn't affect us:
- minimum node version is 8.9.x, we already require 8.10.x
- the limit was "greater than", is now "greater than or equal to"
* Add question issue template

* Fix bug report template formatting

* Fix bug report template formatting

* Add labels to pull request template
* Update deploy instructions in contributing guide

* Update docs publishing instructions
* Added dependencies to bootstrap article when using custom SCSS.

* Make changes to package designation and added npm install directions.
preprocessor will output sourceMap by default
then check if sourceMaps are needed on resolve-url-loader

Fixes facebook#4653
* Adjusted deployment documentation for ZEIT Now

* Fixed missing word

* Update docusaurus/docs/deployment.md

Co-Authored-By: Joe Haddad <[email protected]>
* Remove unused dependencies in babel-preset-react-app

* Re-add @babel/plugin-transform-react-display-name

* Remove some dependencies again
iamandrewluca and others added 29 commits February 2, 2020 12:55
Co-authored-by: Eric Clemmons <[email protected]>
Co-authored-by: Alex Guerra <[email protected]>
Co-authored-by: Kelly <[email protected]>

Co-authored-by: Eric Clemmons <[email protected]>
Co-authored-by: Alex Guerra <[email protected]>
Co-authored-by: Kelly <[email protected]>
- The JavaScript template uses a function declaration to define the component, the TypeScript template and a page of the documentation used arrow functions. Changed it to use function declarations for consistency and readability.
* Downgrade chalk for ie 11 support

* Update lockfile
…acebook#8442)

Moved redirect middleware and noopSW middleware in WDS after hook
So proxy, and before proxy will take precedence before redirect

Closes facebook#8417
webpack should always be written in lower-case, according to webpack's branding guidelines https://webpack.js.org/branding
The http-proxy-middleware package has made a major version upgraded and
introduced a breaking change. This fixes the "Configuring the Proxy
Manually" documentation to match the latest version.
@ArbaazDossani ArbaazDossani merged commit 5b562e9 into master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment