Typescript init: suggest jsx: "react"
in tsconfig
#7472
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transpilation is done by Babel, which ignores the tsconfig, so this setting (or any tsconfig setting) doesn't affect compilation, only type checking.
Setting it to
react
raises a type error if react is not imported, and gives a quick fix to import react. The linter rule does not give a quick fix.I've set it to suggest the value
react
instead of forcing it, because people might need to set it to something else in their project for whatever reason.Verified that it works by cloning create-react-app from master, installing the local versions, and using it to compile a personal project. Setting
"jsx": "react"
does not affect the build size or content.