Update to mraerosol branch from Dom

[climbfuji]

@AnningCheng-NOAA This PR updates your branches with the latest code from main, and contains a few updates for your merra2_aerosol_aware code. Please take a close look and let me know if you have questions. If you agree with the changes, then please merge the PR (this will update your branch in your github fork).

[AnningCheng-NOAA]

HI, Dom: Have you performed a regression test with mraerosol=true and ltaersosol=.false.? Where do you turn offf the reading and writing of nifa_2d and nwfa_2d when mraerosol=True? Changes needed in GFS_diagnostics.F90 to output nifa and nwfa. Anning

…

On Wed, Oct 6, 2021 at 3:58 PM Dom Heinzeller ***@***.***> wrote: @AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> This PR updates your branches with the latest code from main, and contains a few updates for your merra2_aerosol_aware code. Please take a close look and let me know if you have questions. If you agree with the changes, then please merge the PR (this will update your branch in your github fork). ------------------------------ You can view, comment on, or merge this pull request online at: #3 Commit Summary - Add netCDF dependency, rename target to ccpp_physics <d1ac326> - More cleanup in CMakeLists.txt <a9c7465> - Metadata bug fixes and updates <9db88aa> - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into merge_feature_capgen_into_main_20210812 <8bc30ff> - Update submodule pointer for physics/rte-rrtmgp <93368e9> - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into merge_feature_capgen_into_main_20210812 <cfaaaf7> - Revert change to .gitmodules <1f7599a> - Merge pull request #718 from climbfuji/merge_feature_capgen_into_main_20210812 <cabe68f> - Update loop to apply ice adjusted only at non-land points <fb7cfa8> - Metadata bugfixes following CCPP standard name updates <902270f> - Merge pull request #721 from GeorgeGayno-NOAA/feature/sfcsub_fix <1f8cf92> - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into metadata_bugfixes_following_ccpp_standard_name_updates <9a842cb> - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into ccpp_cmake_cleanup <79a5827> - Merge pull request #722 from climbfuji/metadata_bugfixes_following_ccpp_standard_name_updates <cb2b516> - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into ccpp_cmake_cleanup <ec77768> - fixed issue with decomp-change RT failures with ugwpv1 and made other bugfixes <69dc13d> - Add missing dependency on w3nco::w3nco_d <18fb14e> - Merge pull request #705 from climbfuji/ccpp_cmake_cleanup <84c6144> - Make vegetation, slope and soil type integers <074c1b0> - Update physics/GFS_debug.F90 to reflect the recent changes to the GFS DDTs <a442f80> - Add code to reverse changes to vegetation/soil/slope type to GFS_surface_generic_post so that all output files are 100% identical <b063048> - Add logic to save and restore vegetation/soil/slope types before/after surface physics <ac03a54> - Further optimization and code changes for b4b results <d45dc43> - Code cleanup and consistent saving and restoring of vegetation/soil/slope types <a80ad97> - update scm_sfc_flux_spec to work with latest ccpp-physics main <4099a70> - add NoahMP restart fix in GFS_surface_composites.F90 <2a5ebb8> - Merge remote-tracking branch 'grant/SCM_only_20210921' into noahmp_rstfix <a1fd2c6> - add stochastics_init subroutine <34c98c4> - Merge remote-tracking branch 'upstream/main' into new_stochy <6936630> - remove comment line <badab05> - fix decomppsotion issue with cimin <2b1246b> - Merge pull request #732 from junwang-noaa/noahmp_rstfix <a9237ce> - fix to vfact_ca to address levs/levsr issue <2883e06> - Merge remote-tracking branch 'upstream/main' into new_stochy <3c344c5> - fix logic in GFS_stochsatics wrt levs,levsr <099919b> - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into vegetation_soil_slope_type_integer <66c582a> - Merge remote-tracking branch 'upstream/main' into decomp_fix <cf1e9fa> - Merge pull request #742 from junwang-noaa/decomp_fix <c3ff637> - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into vegetation_soil_slope_type_integer <ff71173> - Remove Julie from CODEOWNERS <bbb7861> - Merge branch 'ugwpv1_various_bugfixes' of https://github.com/mdtoy/ccpp-physics into HEAD <565b147> - Merge branch 'feature/julie_retires' of https://github.com/julieschramm/ccpp-physics into HEAD <d935401> - Merge pull request #747 from climbfuji/mike_ugwp_and_julie_codeowner <e22fd68> - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into vegetation_soil_slope_type_integer <f6679e2> - Merge remote-tracking branch 'upstream/main' into new_stochy <b264b9a> - remove redundant copies in Diag container <34ac0f1> - Merge pull request #737 from pjpegion/new_stochy <3c23577> - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into vegetation_soil_slope_type_integer <8763252> - Cleanup work: fix typos, remove old dependencies and comments in source code and metadata files <d29e48b> - Remove stochastic physics arrays that no longer exist from physics/GFS_debug.F90 <9438220> - Fix formatting in physics/GFS_surface_generic.F90 <71832db> - Merge pull request #730 from climbfuji/vegetation_soil_slope_type_integer <2ececb0> - Minor bugfix in GFS_PBL_generic.F90, formatting changes in mp_thompson.F90 <079eb2b> - Merge branch 'mraerosol' of https://github.com/AnningCheng-NOAA/ccpp-physics into HEAD <5df6990> - Bug fixes and updates in module_mp_thompson.F90 and mp_thompson.F90 <2ade7fe> - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into mraerosol_dom <1babf68> - Bug fixes for newly added code in module_mp_thompson.F90 and mp_thompson.F90 <1aa28fb> File Changes - *M* CMakeLists.txt <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a> (57) - *M* CODEOWNERS <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-fcf14c4b7b34fe7a11916195871ae66a59be87a395f28db73e345ebdc828085b> (2) - *M* physics/GFS_DCNV_generic.meta <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-e9e82f06e1bb8f2c02b87285f2f833a9e1c3f4b521b83fcb6ae6a3b47b5356c2> (10) - *M* physics/GFS_MP_generic.meta <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-47bf0db3a49940a587582828d898d7b737393327aa8469cc1b50bc2b4bffcda9> (4) - *M* physics/GFS_PBL_generic.meta <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-e7ff87798e96a6a4c98cd36bccc1fb8d16f6fcd3bed848eb97e582434f7b704f> (2) - *M* physics/GFS_SCNV_generic.meta <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-a761c0144275a0f7d99ed0c60146a0968a49c03d5ebff4dc2b09cbc03ffb2d6b> (2) - *M* physics/GFS_debug.F90 <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-62d882f4fb666287b69196527e450f2ae7c7335c94dba8fd96293402eb391bb0> (180) - *M* physics/GFS_debug.meta <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-1379bf07bac0b2b8a99c8c33786f6dbb470641ea0e32663bf314c1e8ac623201> (37) - *M* physics/GFS_phys_time_vary.fv3.F90 <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-3a65b19ad2c6fc7867b68fe8ec59001d4244ac191e9eaffcff32c677c0c6c42d> (11) - *M* physics/GFS_phys_time_vary.fv3.meta <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-2955225c569ede504cf2be58fe314843070c0f63b3a1b4f000988f1515681dcc> (25) - *M* physics/GFS_phys_time_vary.scm.F90 <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-56a322c1d25816f521b214771d10626170e8b6c7a81838bf8f7d07218ccef07c> (5) - *M* physics/GFS_phys_time_vary.scm.meta <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-fef27f6172735c63219e52606002c99de6280a8f4a9574a8b617b20205bd2fb6> (10) - *M* physics/GFS_radiation_surface.F90 <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-b2a225a87db4ccbbafaf9ec0189a24c811c29069858de4cb193b2fa965697cac> (19) - *M* physics/GFS_radiation_surface.meta <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-f6c7476e0e75063a7cb0742f9f6b9ab5de12e640893399b0cba3682f2dfa5cf9> (9) - *M* physics/GFS_rrtmg_pre.meta <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-3579826173828ced095cc5d5a7a28b2e5d80f0d48dcdb2863f6eab0079564ead> (2) - *M* physics/GFS_rrtmgp_pre.meta <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-9714f1b33e896ce881c20823e3884f5a74b400a772fc3f9e4206150e43a0c89c> (2) - *M* physics/GFS_stochastics.F90 <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-107ed5c023d00c120667871b07b6ba79c29eae1551f2cc196fd1a9e575c75b25> (70) - *M* physics/GFS_stochastics.meta <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-5b041d6173cd4b53764fa99f62c698354cb2def87e720b5b396d3a05fc48e82e> (109) - *M* physics/GFS_suite_interstitial.meta <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-1980deafced886b7492075e3eb0477cf03e8ff861e6253fd8a1b056301489753> (10) - *M* physics/GFS_surface_composites.F90 <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-2517a4717279397b7771521de458a4c38a9c4965eb9bed4748261aebcf6ea97c> (8) - *M* physics/GFS_surface_generic.F90 <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-ece166d17c152acf568102e49774722fa408c300342ca4da831d95bf0cabaa0e> (156) - *M* physics/GFS_surface_generic.meta <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-1b6b027f30a74d0702c9102cfbdbef5afc4c25fe48510736e14c9b95ec9ad724> (339) - *M* physics/cires_ugwpv1_oro.F90 <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-e23ef6f2eedd6f9cf294f9096de7dabcde50a9efe8a455a37ee4fac279243ee1> (4) - *M* physics/drag_suite.F90 <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-95aba6cca4b67b4b1e1f0309cc6e585dee3ca93188e0672d42db349273810c1f> (934) - *M* physics/drag_suite.meta <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-666816892201ebbb1bb3a910d483c81a618442f19518f960d15dd701367e0876> (2) - *M* physics/gcycle.F90 <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-0ef98877318cca302d04ab25b1e5fd5763de081d8a68843da40ed53922e60e06> (22) - *M* physics/module_SGSCloud_RadPre.F90 <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-799375befad584107d4f010fc27e72f8ea50ee54f77c2ecca2c4172f10e9fb6b> (2) - *M* physics/module_mp_thompson.F90 <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-5bf86fc964926b7850d0009e09c945188443c845ef3f734c47a0d2abf65b0e75> (31) - *M* physics/mp_thompson.F90 <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-97f0f6db6de7d85a52ae8e71def6c3a1c301671996f20f69e4302858b1174b48> (68) - *M* physics/radiation_surface.f <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-47cd392f60bc37396692d5e6e6eebd1bf9fe566487ffa71a17e397024a7cd23b> (3) - *M* physics/rrtmg_lw_pre.F90 <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-8b264aa21ff40c4429898c0ee186f1d250c134d1c51081ccf57d53287bfde5ec> (2) - *M* physics/rrtmg_sw_pre.F90 <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-5b24b437c49265bcc9ea71fafd706ee5dc56af478fc8bcb529a59bc21d8575bb> (2) - *M* physics/rrtmg_sw_pre.meta <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-0c5b7ebe707da2e956d1603992b3c8bbe94b675cc12524a03f79ef3e552a14af> (2) - *M* physics/rrtmgp_lw_pre.F90 <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-57c7ce7bb915bfd15a5199eccc2db14c8aba1740702b41c032ac16b0b626882c> (2) - *M* physics/rrtmgp_lw_pre.meta <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-4b56a678cf27711f8156c72b114d694260b52950a75c138de4433031c6785f78> (2) - *M* physics/scm_sfc_flux_spec.F90 <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-a0ad5decd3b1913f155bb5c561032492a2ce02dc12b2953ef8742742e0d232bf> (7) - *M* physics/scm_sfc_flux_spec.meta <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-07a9995773afbc56104ca1ba00e68bc2902badb2defa9cce76855bd630df38d2> (17) - *M* physics/sfc_drv_ruc.F90 <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-efa51899be6f56b83d8739a50a18ebc321ba29e02724715f33674076c4c8ecf5> (108) - *M* physics/sfc_drv_ruc.meta <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-4430a0cba7a4613fc04316e7849e79992903e316ed53b8dc768f1ada4601d270> (18) - *M* physics/sfc_noah_wrfv4_interstitial.F90 <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-1fe92104ed4d211296bbaa271f58c5582eeea0bc1a422d574ecb9514c01ce6e7> (5) - *M* physics/sfc_noah_wrfv4_interstitial.meta <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-5d5b94b0f2bc54889c0f74d5b4ab7fccde3708a6bccbc1816b15ec8f275e8828> (5) - *M* physics/sfcsub.F <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-0a719caf5556adb1de966a49cb3932aa1ed4db107e82ad7c6621e4991c72caeb> (2) - *M* physics/ugwpv1_gsldrag.F90 <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-566ce8850b376476624d893e854508228b09fab258a632d6ae86137f4c5398c6> (5) Patch Links: - https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3.patch - https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3.diff — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALQPMIK5EYMYZ7EZREYTUIDUFSS5LANCNFSM5FPR4CBA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[climbfuji]

Hi Anning, so far I have only compiled it and made sure that the code in ccpp-physics makes sense and doesn't touch nifa/nwfa when mraerosol is true. There were a few bugs in your code that I fixed, and you should see this frorm the diffs in mp_thompson.F90 and module_mp_thompson.F90. Once the ccpp-physics changes are in your branch, I'll work on an fv3atm PR for you. If you have a regression test directory with the correct namelist and input data that you can share with me, I will make sure it runs in debug and prod mode. Thanks, Dom

…

On Oct 7, 2021, at 8:25 AM, AnningCheng-NOAA ***@***.***> wrote: HI, Dom: Have you performed a regression test with mraerosol=true and ltaersosol=.false.? Where do you turn offf the reading and writing of nifa_2d and nwfa_2d when mraerosol=True? Changes needed in GFS_diagnostics.F90 to output nifa and nwfa. Anning On Wed, Oct 6, 2021 at 3:58 PM Dom Heinzeller ***@***.***> wrote: > @AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> This PR updates > your branches with the latest code from main, and contains a few updates > for your merra2_aerosol_aware code. Please take a close look and let me > know if you have questions. If you agree with the changes, then please > merge the PR (this will update your branch in your github fork). > ------------------------------ > You can view, comment on, or merge this pull request online at: > > #3 > Commit Summary > > - Add netCDF dependency, rename target to ccpp_physics > <d1ac326> > - More cleanup in CMakeLists.txt > <a9c7465> > - Metadata bug fixes and updates > <9db88aa> > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > merge_feature_capgen_into_main_20210812 > <8bc30ff> > - Update submodule pointer for physics/rte-rrtmgp > <93368e9> > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > merge_feature_capgen_into_main_20210812 > <cfaaaf7> > - Revert change to .gitmodules > <1f7599a> > - Merge pull request #718 from > climbfuji/merge_feature_capgen_into_main_20210812 > <cabe68f> > - Update loop to apply ice adjusted only at non-land points > <fb7cfa8> > - Metadata bugfixes following CCPP standard name updates > <902270f> > - Merge pull request #721 from GeorgeGayno-NOAA/feature/sfcsub_fix > <1f8cf92> > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > metadata_bugfixes_following_ccpp_standard_name_updates > <9a842cb> > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > ccpp_cmake_cleanup > <79a5827> > - Merge pull request #722 from > climbfuji/metadata_bugfixes_following_ccpp_standard_name_updates > <cb2b516> > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > ccpp_cmake_cleanup > <ec77768> > - fixed issue with decomp-change RT failures with ugwpv1 and made > other bugfixes > <69dc13d> > - Add missing dependency on w3nco::w3nco_d > <18fb14e> > - Merge pull request #705 from climbfuji/ccpp_cmake_cleanup > <84c6144> > - Make vegetation, slope and soil type integers > <074c1b0> > - Update physics/GFS_debug.F90 to reflect the recent changes to the > GFS DDTs > <a442f80> > - Add code to reverse changes to vegetation/soil/slope type to > GFS_surface_generic_post so that all output files are 100% identical > <b063048> > - Add logic to save and restore vegetation/soil/slope types > before/after surface physics > <ac03a54> > - Further optimization and code changes for b4b results > <d45dc43> > - Code cleanup and consistent saving and restoring of > vegetation/soil/slope types > <a80ad97> > - update scm_sfc_flux_spec to work with latest ccpp-physics main > <4099a70> > - add NoahMP restart fix in GFS_surface_composites.F90 > <2a5ebb8> > - Merge remote-tracking branch 'grant/SCM_only_20210921' into > noahmp_rstfix > <a1fd2c6> > - add stochastics_init subroutine > <34c98c4> > - Merge remote-tracking branch 'upstream/main' into new_stochy > <6936630> > - remove comment line > <badab05> > - fix decomppsotion issue with cimin > <2b1246b> > - Merge pull request #732 from junwang-noaa/noahmp_rstfix > <a9237ce> > - fix to vfact_ca to address levs/levsr issue > <2883e06> > - Merge remote-tracking branch 'upstream/main' into new_stochy > <3c344c5> > - fix logic in GFS_stochsatics wrt levs,levsr > <099919b> > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > vegetation_soil_slope_type_integer > <66c582a> > - Merge remote-tracking branch 'upstream/main' into decomp_fix > <cf1e9fa> > - Merge pull request #742 from junwang-noaa/decomp_fix > <c3ff637> > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > vegetation_soil_slope_type_integer > <ff71173> > - Remove Julie from CODEOWNERS > <bbb7861> > - Merge branch 'ugwpv1_various_bugfixes' of > https://github.com/mdtoy/ccpp-physics into HEAD > <565b147> > - Merge branch 'feature/julie_retires' of > https://github.com/julieschramm/ccpp-physics into HEAD > <d935401> > - Merge pull request #747 from climbfuji/mike_ugwp_and_julie_codeowner > <e22fd68> > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > vegetation_soil_slope_type_integer > <f6679e2> > - Merge remote-tracking branch 'upstream/main' into new_stochy > <b264b9a> > - remove redundant copies in Diag container > <34ac0f1> > - Merge pull request #737 from pjpegion/new_stochy > <3c23577> > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > vegetation_soil_slope_type_integer > <8763252> > - Cleanup work: fix typos, remove old dependencies and comments in > source code and metadata files > <d29e48b> > - Remove stochastic physics arrays that no longer exist from > physics/GFS_debug.F90 > <9438220> > - Fix formatting in physics/GFS_surface_generic.F90 > <71832db> > - Merge pull request #730 from > climbfuji/vegetation_soil_slope_type_integer > <2ececb0> > - Minor bugfix in GFS_PBL_generic.F90, formatting changes in > mp_thompson.F90 > <079eb2b> > - Merge branch 'mraerosol' of > https://github.com/AnningCheng-NOAA/ccpp-physics into HEAD > <5df6990> > - Bug fixes and updates in module_mp_thompson.F90 and mp_thompson.F90 > <2ade7fe> > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > mraerosol_dom > <1babf68> > - Bug fixes for newly added code in module_mp_thompson.F90 and > mp_thompson.F90 > <1aa28fb> > > File Changes > > - *M* CMakeLists.txt > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a> > (57) > - *M* CODEOWNERS > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-fcf14c4b7b34fe7a11916195871ae66a59be87a395f28db73e345ebdc828085b> > (2) > - *M* physics/GFS_DCNV_generic.meta > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-e9e82f06e1bb8f2c02b87285f2f833a9e1c3f4b521b83fcb6ae6a3b47b5356c2> > (10) > - *M* physics/GFS_MP_generic.meta > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-47bf0db3a49940a587582828d898d7b737393327aa8469cc1b50bc2b4bffcda9> > (4) > - *M* physics/GFS_PBL_generic.meta > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-e7ff87798e96a6a4c98cd36bccc1fb8d16f6fcd3bed848eb97e582434f7b704f> > (2) > - *M* physics/GFS_SCNV_generic.meta > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-a761c0144275a0f7d99ed0c60146a0968a49c03d5ebff4dc2b09cbc03ffb2d6b> > (2) > - *M* physics/GFS_debug.F90 > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-62d882f4fb666287b69196527e450f2ae7c7335c94dba8fd96293402eb391bb0> > (180) > - *M* physics/GFS_debug.meta > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-1379bf07bac0b2b8a99c8c33786f6dbb470641ea0e32663bf314c1e8ac623201> > (37) > - *M* physics/GFS_phys_time_vary.fv3.F90 > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-3a65b19ad2c6fc7867b68fe8ec59001d4244ac191e9eaffcff32c677c0c6c42d> > (11) > - *M* physics/GFS_phys_time_vary.fv3.meta > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-2955225c569ede504cf2be58fe314843070c0f63b3a1b4f000988f1515681dcc> > (25) > - *M* physics/GFS_phys_time_vary.scm.F90 > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-56a322c1d25816f521b214771d10626170e8b6c7a81838bf8f7d07218ccef07c> > (5) > - *M* physics/GFS_phys_time_vary.scm.meta > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-fef27f6172735c63219e52606002c99de6280a8f4a9574a8b617b20205bd2fb6> > (10) > - *M* physics/GFS_radiation_surface.F90 > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-b2a225a87db4ccbbafaf9ec0189a24c811c29069858de4cb193b2fa965697cac> > (19) > - *M* physics/GFS_radiation_surface.meta > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-f6c7476e0e75063a7cb0742f9f6b9ab5de12e640893399b0cba3682f2dfa5cf9> > (9) > - *M* physics/GFS_rrtmg_pre.meta > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-3579826173828ced095cc5d5a7a28b2e5d80f0d48dcdb2863f6eab0079564ead> > (2) > - *M* physics/GFS_rrtmgp_pre.meta > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-9714f1b33e896ce881c20823e3884f5a74b400a772fc3f9e4206150e43a0c89c> > (2) > - *M* physics/GFS_stochastics.F90 > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-107ed5c023d00c120667871b07b6ba79c29eae1551f2cc196fd1a9e575c75b25> > (70) > - *M* physics/GFS_stochastics.meta > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-5b041d6173cd4b53764fa99f62c698354cb2def87e720b5b396d3a05fc48e82e> > (109) > - *M* physics/GFS_suite_interstitial.meta > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-1980deafced886b7492075e3eb0477cf03e8ff861e6253fd8a1b056301489753> > (10) > - *M* physics/GFS_surface_composites.F90 > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-2517a4717279397b7771521de458a4c38a9c4965eb9bed4748261aebcf6ea97c> > (8) > - *M* physics/GFS_surface_generic.F90 > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-ece166d17c152acf568102e49774722fa408c300342ca4da831d95bf0cabaa0e> > (156) > - *M* physics/GFS_surface_generic.meta > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-1b6b027f30a74d0702c9102cfbdbef5afc4c25fe48510736e14c9b95ec9ad724> > (339) > - *M* physics/cires_ugwpv1_oro.F90 > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-e23ef6f2eedd6f9cf294f9096de7dabcde50a9efe8a455a37ee4fac279243ee1> > (4) > - *M* physics/drag_suite.F90 > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-95aba6cca4b67b4b1e1f0309cc6e585dee3ca93188e0672d42db349273810c1f> > (934) > - *M* physics/drag_suite.meta > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-666816892201ebbb1bb3a910d483c81a618442f19518f960d15dd701367e0876> > (2) > - *M* physics/gcycle.F90 > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-0ef98877318cca302d04ab25b1e5fd5763de081d8a68843da40ed53922e60e06> > (22) > - *M* physics/module_SGSCloud_RadPre.F90 > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-799375befad584107d4f010fc27e72f8ea50ee54f77c2ecca2c4172f10e9fb6b> > (2) > - *M* physics/module_mp_thompson.F90 > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-5bf86fc964926b7850d0009e09c945188443c845ef3f734c47a0d2abf65b0e75> > (31) > - *M* physics/mp_thompson.F90 > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-97f0f6db6de7d85a52ae8e71def6c3a1c301671996f20f69e4302858b1174b48> > (68) > - *M* physics/radiation_surface.f > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-47cd392f60bc37396692d5e6e6eebd1bf9fe566487ffa71a17e397024a7cd23b> > (3) > - *M* physics/rrtmg_lw_pre.F90 > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-8b264aa21ff40c4429898c0ee186f1d250c134d1c51081ccf57d53287bfde5ec> > (2) > - *M* physics/rrtmg_sw_pre.F90 > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-5b24b437c49265bcc9ea71fafd706ee5dc56af478fc8bcb529a59bc21d8575bb> > (2) > - *M* physics/rrtmg_sw_pre.meta > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-0c5b7ebe707da2e956d1603992b3c8bbe94b675cc12524a03f79ef3e552a14af> > (2) > - *M* physics/rrtmgp_lw_pre.F90 > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-57c7ce7bb915bfd15a5199eccc2db14c8aba1740702b41c032ac16b0b626882c> > (2) > - *M* physics/rrtmgp_lw_pre.meta > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-4b56a678cf27711f8156c72b114d694260b52950a75c138de4433031c6785f78> > (2) > - *M* physics/scm_sfc_flux_spec.F90 > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-a0ad5decd3b1913f155bb5c561032492a2ce02dc12b2953ef8742742e0d232bf> > (7) > - *M* physics/scm_sfc_flux_spec.meta > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-07a9995773afbc56104ca1ba00e68bc2902badb2defa9cce76855bd630df38d2> > (17) > - *M* physics/sfc_drv_ruc.F90 > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-efa51899be6f56b83d8739a50a18ebc321ba29e02724715f33674076c4c8ecf5> > (108) > - *M* physics/sfc_drv_ruc.meta > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-4430a0cba7a4613fc04316e7849e79992903e316ed53b8dc768f1ada4601d270> > (18) > - *M* physics/sfc_noah_wrfv4_interstitial.F90 > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-1fe92104ed4d211296bbaa271f58c5582eeea0bc1a422d574ecb9514c01ce6e7> > (5) > - *M* physics/sfc_noah_wrfv4_interstitial.meta > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-5d5b94b0f2bc54889c0f74d5b4ab7fccde3708a6bccbc1816b15ec8f275e8828> > (5) > - *M* physics/sfcsub.F > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-0a719caf5556adb1de966a49cb3932aa1ed4db107e82ad7c6621e4991c72caeb> > (2) > - *M* physics/ugwpv1_gsldrag.F90 > <https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-566ce8850b376476624d893e854508228b09fab258a632d6ae86137f4c5398c6> > (5) > > Patch Links: > > - https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3.patch > - https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3.diff > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#3>, or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ALQPMIK5EYMYZ7EZREYTUIDUFSS5LANCNFSM5FPR4CBA> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2ROKR4PPGE37PKY6DF3UFWUVPANCNFSM5FPR4CBA>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[AnningCheng-NOAA]

Dom, I have just merged the PR and clone to my local disk at /scratch1/NCEPDEV/global/Anning.Cheng/ufs-weather-model. When I run rt.sh -kc -l rt.conf1 > & o1 at ufs-weather-model/tests, I get a compilation error /scratch1/NCEPDEV/global/Anning.Cheng/ufs-weather-model/tests/build_fv3_001/FV3/ccpp/ccpp_prebuild.err Something to do with the soil type. Could you take a look? Anning On Thu, Oct 7, 2021 at 11:41 AM Dom Heinzeller ***@***.***> wrote:

…

Hi Anning, so far I have only compiled it and made sure that the code in ccpp-physics makes sense and doesn't touch nifa/nwfa when mraerosol is true. There were a few bugs in your code that I fixed, and you should see this frorm the diffs in mp_thompson.F90 and module_mp_thompson.F90. Once the ccpp-physics changes are in your branch, I'll work on an fv3atm PR for you. If you have a regression test directory with the correct namelist and input data that you can share with me, I will make sure it runs in debug and prod mode. Thanks, Dom > On Oct 7, 2021, at 8:25 AM, AnningCheng-NOAA ***@***.***> wrote: > > > HI, Dom: > > Have you performed a regression test with mraerosol=true and > ltaersosol=.false.? Where do you turn offf the reading and writing of > nifa_2d and nwfa_2d when mraerosol=True? Changes needed > in GFS_diagnostics.F90 to output nifa and nwfa. > > > Anning > > > On Wed, Oct 6, 2021 at 3:58 PM Dom Heinzeller ***@***.***> > wrote: > > > @AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> This PR updates > > your branches with the latest code from main, and contains a few updates > > for your merra2_aerosol_aware code. Please take a close look and let me > > know if you have questions. If you agree with the changes, then please > > merge the PR (this will update your branch in your github fork). > > ------------------------------ > > You can view, comment on, or merge this pull request online at: > > > > #3 > > Commit Summary > > > > - Add netCDF dependency, rename target to ccpp_physics > > < d1ac326 > > > - More cleanup in CMakeLists.txt > > < a9c7465 > > > - Metadata bug fixes and updates > > < 9db88aa > > > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > > merge_feature_capgen_into_main_20210812 > > < 8bc30ff > > > - Update submodule pointer for physics/rte-rrtmgp > > < 93368e9 > > > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > > merge_feature_capgen_into_main_20210812 > > < cfaaaf7 > > > - Revert change to .gitmodules > > < 1f7599a > > > - Merge pull request #718 from > > climbfuji/merge_feature_capgen_into_main_20210812 > > < cabe68f > > > - Update loop to apply ice adjusted only at non-land points > > < fb7cfa8 > > > - Metadata bugfixes following CCPP standard name updates > > < 902270f > > > - Merge pull request #721 from GeorgeGayno-NOAA/feature/sfcsub_fix > > < 1f8cf92 > > > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > > metadata_bugfixes_following_ccpp_standard_name_updates > > < 9a842cb > > > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > > ccpp_cmake_cleanup > > < 79a5827 > > > - Merge pull request #722 from > > climbfuji/metadata_bugfixes_following_ccpp_standard_name_updates > > < cb2b516 > > > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > > ccpp_cmake_cleanup > > < ec77768 > > > - fixed issue with decomp-change RT failures with ugwpv1 and made > > other bugfixes > > < 69dc13d > > > - Add missing dependency on w3nco::w3nco_d > > < 18fb14e > > > - Merge pull request #705 from climbfuji/ccpp_cmake_cleanup > > < 84c6144 > > > - Make vegetation, slope and soil type integers > > < 074c1b0 > > > - Update physics/GFS_debug.F90 to reflect the recent changes to the > > GFS DDTs > > < a442f80 > > > - Add code to reverse changes to vegetation/soil/slope type to > > GFS_surface_generic_post so that all output files are 100% identical > > < b063048 > > > - Add logic to save and restore vegetation/soil/slope types > > before/after surface physics > > < ac03a54 > > > - Further optimization and code changes for b4b results > > < d45dc43 > > > - Code cleanup and consistent saving and restoring of > > vegetation/soil/slope types > > < a80ad97 > > > - update scm_sfc_flux_spec to work with latest ccpp-physics main > > < 4099a70 > > > - add NoahMP restart fix in GFS_surface_composites.F90 > > < 2a5ebb8 > > > - Merge remote-tracking branch 'grant/SCM_only_20210921' into > > noahmp_rstfix > > < a1fd2c6 > > > - add stochastics_init subroutine > > < 34c98c4 > > > - Merge remote-tracking branch 'upstream/main' into new_stochy > > < 6936630 > > > - remove comment line > > < badab05 > > > - fix decomppsotion issue with cimin > > < 2b1246b > > > - Merge pull request #732 from junwang-noaa/noahmp_rstfix > > < a9237ce > > > - fix to vfact_ca to address levs/levsr issue > > < 2883e06 > > > - Merge remote-tracking branch 'upstream/main' into new_stochy > > < 3c344c5 > > > - fix logic in GFS_stochsatics wrt levs,levsr > > < 099919b > > > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > > vegetation_soil_slope_type_integer > > < 66c582a > > > - Merge remote-tracking branch 'upstream/main' into decomp_fix > > < cf1e9fa > > > - Merge pull request #742 from junwang-noaa/decomp_fix > > < c3ff637 > > > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > > vegetation_soil_slope_type_integer > > < ff71173 > > > - Remove Julie from CODEOWNERS > > < bbb7861 > > > - Merge branch 'ugwpv1_various_bugfixes' of > > https://github.com/mdtoy/ccpp-physics into HEAD > > < 565b147 > > > - Merge branch 'feature/julie_retires' of > > https://github.com/julieschramm/ccpp-physics into HEAD > > < d935401 > > > - Merge pull request #747 from climbfuji/mike_ugwp_and_julie_codeowner > > < e22fd68 > > > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > > vegetation_soil_slope_type_integer > > < f6679e2 > > > - Merge remote-tracking branch 'upstream/main' into new_stochy > > < b264b9a > > > - remove redundant copies in Diag container > > < 34ac0f1 > > > - Merge pull request #737 from pjpegion/new_stochy > > < 3c23577 > > > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > > vegetation_soil_slope_type_integer > > < 8763252 > > > - Cleanup work: fix typos, remove old dependencies and comments in > > source code and metadata files > > < d29e48b > > > - Remove stochastic physics arrays that no longer exist from > > physics/GFS_debug.F90 > > < 9438220 > > > - Fix formatting in physics/GFS_surface_generic.F90 > > < 71832db > > > - Merge pull request #730 from > > climbfuji/vegetation_soil_slope_type_integer > > < 2ececb0 > > > - Minor bugfix in GFS_PBL_generic.F90, formatting changes in > > mp_thompson.F90 > > < 079eb2b > > > - Merge branch 'mraerosol' of > > https://github.com/AnningCheng-NOAA/ccpp-physics into HEAD > > < 5df6990 > > > - Bug fixes and updates in module_mp_thompson.F90 and mp_thompson.F90 > > < 2ade7fe > > > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > > mraerosol_dom > > < 1babf68 > > > - Bug fixes for newly added code in module_mp_thompson.F90 and > > mp_thompson.F90 > > < 1aa28fb > > > > > File Changes > > > > - *M* CMakeLists.txt > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a > > > (57) > > - *M* CODEOWNERS > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-fcf14c4b7b34fe7a11916195871ae66a59be87a395f28db73e345ebdc828085b > > > (2) > > - *M* physics/GFS_DCNV_generic.meta > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-e9e82f06e1bb8f2c02b87285f2f833a9e1c3f4b521b83fcb6ae6a3b47b5356c2 > > > (10) > > - *M* physics/GFS_MP_generic.meta > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-47bf0db3a49940a587582828d898d7b737393327aa8469cc1b50bc2b4bffcda9 > > > (4) > > - *M* physics/GFS_PBL_generic.meta > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-e7ff87798e96a6a4c98cd36bccc1fb8d16f6fcd3bed848eb97e582434f7b704f > > > (2) > > - *M* physics/GFS_SCNV_generic.meta > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-a761c0144275a0f7d99ed0c60146a0968a49c03d5ebff4dc2b09cbc03ffb2d6b > > > (2) > > - *M* physics/GFS_debug.F90 > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-62d882f4fb666287b69196527e450f2ae7c7335c94dba8fd96293402eb391bb0 > > > (180) > > - *M* physics/GFS_debug.meta > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-1379bf07bac0b2b8a99c8c33786f6dbb470641ea0e32663bf314c1e8ac623201 > > > (37) > > - *M* physics/GFS_phys_time_vary.fv3.F90 > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-3a65b19ad2c6fc7867b68fe8ec59001d4244ac191e9eaffcff32c677c0c6c42d > > > (11) > > - *M* physics/GFS_phys_time_vary.fv3.meta > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-2955225c569ede504cf2be58fe314843070c0f63b3a1b4f000988f1515681dcc > > > (25) > > - *M* physics/GFS_phys_time_vary.scm.F90 > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-56a322c1d25816f521b214771d10626170e8b6c7a81838bf8f7d07218ccef07c > > > (5) > > - *M* physics/GFS_phys_time_vary.scm.meta > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-fef27f6172735c63219e52606002c99de6280a8f4a9574a8b617b20205bd2fb6 > > > (10) > > - *M* physics/GFS_radiation_surface.F90 > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-b2a225a87db4ccbbafaf9ec0189a24c811c29069858de4cb193b2fa965697cac > > > (19) > > - *M* physics/GFS_radiation_surface.meta > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-f6c7476e0e75063a7cb0742f9f6b9ab5de12e640893399b0cba3682f2dfa5cf9 > > > (9) > > - *M* physics/GFS_rrtmg_pre.meta > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-3579826173828ced095cc5d5a7a28b2e5d80f0d48dcdb2863f6eab0079564ead > > > (2) > > - *M* physics/GFS_rrtmgp_pre.meta > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-9714f1b33e896ce881c20823e3884f5a74b400a772fc3f9e4206150e43a0c89c > > > (2) > > - *M* physics/GFS_stochastics.F90 > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-107ed5c023d00c120667871b07b6ba79c29eae1551f2cc196fd1a9e575c75b25 > > > (70) > > - *M* physics/GFS_stochastics.meta > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-5b041d6173cd4b53764fa99f62c698354cb2def87e720b5b396d3a05fc48e82e > > > (109) > > - *M* physics/GFS_suite_interstitial.meta > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-1980deafced886b7492075e3eb0477cf03e8ff861e6253fd8a1b056301489753 > > > (10) > > - *M* physics/GFS_surface_composites.F90 > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-2517a4717279397b7771521de458a4c38a9c4965eb9bed4748261aebcf6ea97c > > > (8) > > - *M* physics/GFS_surface_generic.F90 > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-ece166d17c152acf568102e49774722fa408c300342ca4da831d95bf0cabaa0e > > > (156) > > - *M* physics/GFS_surface_generic.meta > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-1b6b027f30a74d0702c9102cfbdbef5afc4c25fe48510736e14c9b95ec9ad724 > > > (339) > > - *M* physics/cires_ugwpv1_oro.F90 > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-e23ef6f2eedd6f9cf294f9096de7dabcde50a9efe8a455a37ee4fac279243ee1 > > > (4) > > - *M* physics/drag_suite.F90 > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-95aba6cca4b67b4b1e1f0309cc6e585dee3ca93188e0672d42db349273810c1f > > > (934) > > - *M* physics/drag_suite.meta > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-666816892201ebbb1bb3a910d483c81a618442f19518f960d15dd701367e0876 > > > (2) > > - *M* physics/gcycle.F90 > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-0ef98877318cca302d04ab25b1e5fd5763de081d8a68843da40ed53922e60e06 > > > (22) > > - *M* physics/module_SGSCloud_RadPre.F90 > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-799375befad584107d4f010fc27e72f8ea50ee54f77c2ecca2c4172f10e9fb6b > > > (2) > > - *M* physics/module_mp_thompson.F90 > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-5bf86fc964926b7850d0009e09c945188443c845ef3f734c47a0d2abf65b0e75 > > > (31) > > - *M* physics/mp_thompson.F90 > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-97f0f6db6de7d85a52ae8e71def6c3a1c301671996f20f69e4302858b1174b48 > > > (68) > > - *M* physics/radiation_surface.f > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-47cd392f60bc37396692d5e6e6eebd1bf9fe566487ffa71a17e397024a7cd23b > > > (3) > > - *M* physics/rrtmg_lw_pre.F90 > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-8b264aa21ff40c4429898c0ee186f1d250c134d1c51081ccf57d53287bfde5ec > > > (2) > > - *M* physics/rrtmg_sw_pre.F90 > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-5b24b437c49265bcc9ea71fafd706ee5dc56af478fc8bcb529a59bc21d8575bb > > > (2) > > - *M* physics/rrtmg_sw_pre.meta > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-0c5b7ebe707da2e956d1603992b3c8bbe94b675cc12524a03f79ef3e552a14af > > > (2) > > - *M* physics/rrtmgp_lw_pre.F90 > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-57c7ce7bb915bfd15a5199eccc2db14c8aba1740702b41c032ac16b0b626882c > > > (2) > > - *M* physics/rrtmgp_lw_pre.meta > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-4b56a678cf27711f8156c72b114d694260b52950a75c138de4433031c6785f78 > > > (2) > > - *M* physics/scm_sfc_flux_spec.F90 > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-a0ad5decd3b1913f155bb5c561032492a2ce02dc12b2953ef8742742e0d232bf > > > (7) > > - *M* physics/scm_sfc_flux_spec.meta > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-07a9995773afbc56104ca1ba00e68bc2902badb2defa9cce76855bd630df38d2 > > > (17) > > - *M* physics/sfc_drv_ruc.F90 > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-efa51899be6f56b83d8739a50a18ebc321ba29e02724715f33674076c4c8ecf5 > > > (108) > > - *M* physics/sfc_drv_ruc.meta > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-4430a0cba7a4613fc04316e7849e79992903e316ed53b8dc768f1ada4601d270 > > > (18) > > - *M* physics/sfc_noah_wrfv4_interstitial.F90 > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-1fe92104ed4d211296bbaa271f58c5582eeea0bc1a422d574ecb9514c01ce6e7 > > > (5) > > - *M* physics/sfc_noah_wrfv4_interstitial.meta > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-5d5b94b0f2bc54889c0f74d5b4ab7fccde3708a6bccbc1816b15ec8f275e8828 > > > (5) > > - *M* physics/sfcsub.F > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-0a719caf5556adb1de966a49cb3932aa1ed4db107e82ad7c6621e4991c72caeb > > > (2) > > - *M* physics/ugwpv1_gsldrag.F90 > > < https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-566ce8850b376476624d893e854508228b09fab258a632d6ae86137f4c5398c6 > > > (5) > > > > Patch Links: > > > > - https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3.patch > > - https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3.diff > > > > — > > You are receiving this because you were mentioned. > > Reply to this email directly, view it on GitHub > > <#3>, or unsubscribe > > < https://github.com/notifications/unsubscribe-auth/ALQPMIK5EYMYZ7EZREYTUIDUFSS5LANCNFSM5FPR4CBA > > > . > > Triage notifications on the go with GitHub Mobile for iOS > > < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 > > > or Android > > < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub >. > > > > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub < #3 (comment)>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AB5C2ROKR4PPGE37PKY6DF3UFWUVPANCNFSM5FPR4CBA >. > Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALQPMIKOXWUBXVJRT5WU5ETUFW5Q3ANCNFSM5FPR4CBA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[climbfuji]

You need to pull in the latest fv3atm code from develop, because I updated your ccpp-physics code to the top of main. Let me send you a first PR for fv3atm today/tomorrow. This won't have the GFS_diagnostics changes yet, but at least all the updates from develop.

…

On Oct 7, 2021, at 1:41 PM, AnningCheng-NOAA ***@***.***> wrote: Dom, I have just merged the PR and clone to my local disk at /scratch1/NCEPDEV/global/Anning.Cheng/ufs-weather-model. When I run rt.sh -kc -l rt.conf1 > & o1 at ufs-weather-model/tests, I get a compilation error /scratch1/NCEPDEV/global/Anning.Cheng/ufs-weather-model/tests/build_fv3_001/FV3/ccpp/ccpp_prebuild.err Something to do with the soil type. Could you take a look? Anning On Thu, Oct 7, 2021 at 11:41 AM Dom Heinzeller ***@***.***> wrote: > Hi Anning, > > so far I have only compiled it and made sure that the code in ccpp-physics > makes sense and doesn't touch nifa/nwfa when mraerosol is true. There were > a few bugs in your code that I fixed, and you should see this frorm the > diffs in mp_thompson.F90 and module_mp_thompson.F90. > > Once the ccpp-physics changes are in your branch, I'll work on an fv3atm > PR for you. > > If you have a regression test directory with the correct namelist and > input data that you can share with me, I will make sure it runs in debug > and prod mode. > > Thanks, > > Dom > > > On Oct 7, 2021, at 8:25 AM, AnningCheng-NOAA ***@***.***> wrote: > > > > > > HI, Dom: > > > > Have you performed a regression test with mraerosol=true and > > ltaersosol=.false.? Where do you turn offf the reading and writing of > > nifa_2d and nwfa_2d when mraerosol=True? Changes needed > > in GFS_diagnostics.F90 to output nifa and nwfa. > > > > > > Anning > > > > > > On Wed, Oct 6, 2021 at 3:58 PM Dom Heinzeller ***@***.***> > > wrote: > > > > > @AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> This PR > updates > > > your branches with the latest code from main, and contains a few > updates > > > for your merra2_aerosol_aware code. Please take a close look and let me > > > know if you have questions. If you agree with the changes, then please > > > merge the PR (this will update your branch in your github fork). > > > ------------------------------ > > > You can view, comment on, or merge this pull request online at: > > > > > > #3 > > > Commit Summary > > > > > > - Add netCDF dependency, rename target to ccpp_physics > > > < > d1ac326 > > > > > - More cleanup in CMakeLists.txt > > > < > a9c7465 > > > > > - Metadata bug fixes and updates > > > < > 9db88aa > > > > > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > > > merge_feature_capgen_into_main_20210812 > > > < > 8bc30ff > > > > > - Update submodule pointer for physics/rte-rrtmgp > > > < > 93368e9 > > > > > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > > > merge_feature_capgen_into_main_20210812 > > > < > cfaaaf7 > > > > > - Revert change to .gitmodules > > > < > 1f7599a > > > > > - Merge pull request #718 from > > > climbfuji/merge_feature_capgen_into_main_20210812 > > > < > cabe68f > > > > > - Update loop to apply ice adjusted only at non-land points > > > < > fb7cfa8 > > > > > - Metadata bugfixes following CCPP standard name updates > > > < > 902270f > > > > > - Merge pull request #721 from GeorgeGayno-NOAA/feature/sfcsub_fix > > > < > 1f8cf92 > > > > > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > > > metadata_bugfixes_following_ccpp_standard_name_updates > > > < > 9a842cb > > > > > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > > > ccpp_cmake_cleanup > > > < > 79a5827 > > > > > - Merge pull request #722 from > > > climbfuji/metadata_bugfixes_following_ccpp_standard_name_updates > > > < > cb2b516 > > > > > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > > > ccpp_cmake_cleanup > > > < > ec77768 > > > > > - fixed issue with decomp-change RT failures with ugwpv1 and made > > > other bugfixes > > > < > 69dc13d > > > > > - Add missing dependency on w3nco::w3nco_d > > > < > 18fb14e > > > > > - Merge pull request #705 from climbfuji/ccpp_cmake_cleanup > > > < > 84c6144 > > > > > - Make vegetation, slope and soil type integers > > > < > 074c1b0 > > > > > - Update physics/GFS_debug.F90 to reflect the recent changes to the > > > GFS DDTs > > > < > a442f80 > > > > > - Add code to reverse changes to vegetation/soil/slope type to > > > GFS_surface_generic_post so that all output files are 100% identical > > > < > b063048 > > > > > - Add logic to save and restore vegetation/soil/slope types > > > before/after surface physics > > > < > ac03a54 > > > > > - Further optimization and code changes for b4b results > > > < > d45dc43 > > > > > - Code cleanup and consistent saving and restoring of > > > vegetation/soil/slope types > > > < > a80ad97 > > > > > - update scm_sfc_flux_spec to work with latest ccpp-physics main > > > < > 4099a70 > > > > > - add NoahMP restart fix in GFS_surface_composites.F90 > > > < > 2a5ebb8 > > > > > - Merge remote-tracking branch 'grant/SCM_only_20210921' into > > > noahmp_rstfix > > > < > a1fd2c6 > > > > > - add stochastics_init subroutine > > > < > 34c98c4 > > > > > - Merge remote-tracking branch 'upstream/main' into new_stochy > > > < > 6936630 > > > > > - remove comment line > > > < > badab05 > > > > > - fix decomppsotion issue with cimin > > > < > 2b1246b > > > > > - Merge pull request #732 from junwang-noaa/noahmp_rstfix > > > < > a9237ce > > > > > - fix to vfact_ca to address levs/levsr issue > > > < > 2883e06 > > > > > - Merge remote-tracking branch 'upstream/main' into new_stochy > > > < > 3c344c5 > > > > > - fix logic in GFS_stochsatics wrt levs,levsr > > > < > 099919b > > > > > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > > > vegetation_soil_slope_type_integer > > > < > 66c582a > > > > > - Merge remote-tracking branch 'upstream/main' into decomp_fix > > > < > cf1e9fa > > > > > - Merge pull request #742 from junwang-noaa/decomp_fix > > > < > c3ff637 > > > > > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > > > vegetation_soil_slope_type_integer > > > < > ff71173 > > > > > - Remove Julie from CODEOWNERS > > > < > bbb7861 > > > > > - Merge branch 'ugwpv1_various_bugfixes' of > > > https://github.com/mdtoy/ccpp-physics into HEAD > > > < > 565b147 > > > > > - Merge branch 'feature/julie_retires' of > > > https://github.com/julieschramm/ccpp-physics into HEAD > > > < > d935401 > > > > > - Merge pull request #747 from climbfuji/mike_ugwp_and_julie_codeowner > > > < > e22fd68 > > > > > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > > > vegetation_soil_slope_type_integer > > > < > f6679e2 > > > > > - Merge remote-tracking branch 'upstream/main' into new_stochy > > > < > b264b9a > > > > > - remove redundant copies in Diag container > > > < > 34ac0f1 > > > > > - Merge pull request #737 from pjpegion/new_stochy > > > < > 3c23577 > > > > > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > > > vegetation_soil_slope_type_integer > > > < > 8763252 > > > > > - Cleanup work: fix typos, remove old dependencies and comments in > > > source code and metadata files > > > < > d29e48b > > > > > - Remove stochastic physics arrays that no longer exist from > > > physics/GFS_debug.F90 > > > < > 9438220 > > > > > - Fix formatting in physics/GFS_surface_generic.F90 > > > < > 71832db > > > > > - Merge pull request #730 from > > > climbfuji/vegetation_soil_slope_type_integer > > > < > 2ececb0 > > > > > - Minor bugfix in GFS_PBL_generic.F90, formatting changes in > > > mp_thompson.F90 > > > < > 079eb2b > > > > > - Merge branch 'mraerosol' of > > > https://github.com/AnningCheng-NOAA/ccpp-physics into HEAD > > > < > 5df6990 > > > > > - Bug fixes and updates in module_mp_thompson.F90 and mp_thompson.F90 > > > < > 2ade7fe > > > > > - Merge branch 'main' of https://github.com/NCAR/ccpp-physics into > > > mraerosol_dom > > > < > 1babf68 > > > > > - Bug fixes for newly added code in module_mp_thompson.F90 and > > > mp_thompson.F90 > > > < > 1aa28fb > > > > > > > > File Changes > > > > > > - *M* CMakeLists.txt > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a > > > > > (57) > > > - *M* CODEOWNERS > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-fcf14c4b7b34fe7a11916195871ae66a59be87a395f28db73e345ebdc828085b > > > > > (2) > > > - *M* physics/GFS_DCNV_generic.meta > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-e9e82f06e1bb8f2c02b87285f2f833a9e1c3f4b521b83fcb6ae6a3b47b5356c2 > > > > > (10) > > > - *M* physics/GFS_MP_generic.meta > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-47bf0db3a49940a587582828d898d7b737393327aa8469cc1b50bc2b4bffcda9 > > > > > (4) > > > - *M* physics/GFS_PBL_generic.meta > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-e7ff87798e96a6a4c98cd36bccc1fb8d16f6fcd3bed848eb97e582434f7b704f > > > > > (2) > > > - *M* physics/GFS_SCNV_generic.meta > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-a761c0144275a0f7d99ed0c60146a0968a49c03d5ebff4dc2b09cbc03ffb2d6b > > > > > (2) > > > - *M* physics/GFS_debug.F90 > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-62d882f4fb666287b69196527e450f2ae7c7335c94dba8fd96293402eb391bb0 > > > > > (180) > > > - *M* physics/GFS_debug.meta > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-1379bf07bac0b2b8a99c8c33786f6dbb470641ea0e32663bf314c1e8ac623201 > > > > > (37) > > > - *M* physics/GFS_phys_time_vary.fv3.F90 > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-3a65b19ad2c6fc7867b68fe8ec59001d4244ac191e9eaffcff32c677c0c6c42d > > > > > (11) > > > - *M* physics/GFS_phys_time_vary.fv3.meta > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-2955225c569ede504cf2be58fe314843070c0f63b3a1b4f000988f1515681dcc > > > > > (25) > > > - *M* physics/GFS_phys_time_vary.scm.F90 > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-56a322c1d25816f521b214771d10626170e8b6c7a81838bf8f7d07218ccef07c > > > > > (5) > > > - *M* physics/GFS_phys_time_vary.scm.meta > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-fef27f6172735c63219e52606002c99de6280a8f4a9574a8b617b20205bd2fb6 > > > > > (10) > > > - *M* physics/GFS_radiation_surface.F90 > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-b2a225a87db4ccbbafaf9ec0189a24c811c29069858de4cb193b2fa965697cac > > > > > (19) > > > - *M* physics/GFS_radiation_surface.meta > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-f6c7476e0e75063a7cb0742f9f6b9ab5de12e640893399b0cba3682f2dfa5cf9 > > > > > (9) > > > - *M* physics/GFS_rrtmg_pre.meta > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-3579826173828ced095cc5d5a7a28b2e5d80f0d48dcdb2863f6eab0079564ead > > > > > (2) > > > - *M* physics/GFS_rrtmgp_pre.meta > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-9714f1b33e896ce881c20823e3884f5a74b400a772fc3f9e4206150e43a0c89c > > > > > (2) > > > - *M* physics/GFS_stochastics.F90 > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-107ed5c023d00c120667871b07b6ba79c29eae1551f2cc196fd1a9e575c75b25 > > > > > (70) > > > - *M* physics/GFS_stochastics.meta > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-5b041d6173cd4b53764fa99f62c698354cb2def87e720b5b396d3a05fc48e82e > > > > > (109) > > > - *M* physics/GFS_suite_interstitial.meta > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-1980deafced886b7492075e3eb0477cf03e8ff861e6253fd8a1b056301489753 > > > > > (10) > > > - *M* physics/GFS_surface_composites.F90 > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-2517a4717279397b7771521de458a4c38a9c4965eb9bed4748261aebcf6ea97c > > > > > (8) > > > - *M* physics/GFS_surface_generic.F90 > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-ece166d17c152acf568102e49774722fa408c300342ca4da831d95bf0cabaa0e > > > > > (156) > > > - *M* physics/GFS_surface_generic.meta > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-1b6b027f30a74d0702c9102cfbdbef5afc4c25fe48510736e14c9b95ec9ad724 > > > > > (339) > > > - *M* physics/cires_ugwpv1_oro.F90 > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-e23ef6f2eedd6f9cf294f9096de7dabcde50a9efe8a455a37ee4fac279243ee1 > > > > > (4) > > > - *M* physics/drag_suite.F90 > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-95aba6cca4b67b4b1e1f0309cc6e585dee3ca93188e0672d42db349273810c1f > > > > > (934) > > > - *M* physics/drag_suite.meta > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-666816892201ebbb1bb3a910d483c81a618442f19518f960d15dd701367e0876 > > > > > (2) > > > - *M* physics/gcycle.F90 > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-0ef98877318cca302d04ab25b1e5fd5763de081d8a68843da40ed53922e60e06 > > > > > (22) > > > - *M* physics/module_SGSCloud_RadPre.F90 > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-799375befad584107d4f010fc27e72f8ea50ee54f77c2ecca2c4172f10e9fb6b > > > > > (2) > > > - *M* physics/module_mp_thompson.F90 > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-5bf86fc964926b7850d0009e09c945188443c845ef3f734c47a0d2abf65b0e75 > > > > > (31) > > > - *M* physics/mp_thompson.F90 > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-97f0f6db6de7d85a52ae8e71def6c3a1c301671996f20f69e4302858b1174b48 > > > > > (68) > > > - *M* physics/radiation_surface.f > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-47cd392f60bc37396692d5e6e6eebd1bf9fe566487ffa71a17e397024a7cd23b > > > > > (3) > > > - *M* physics/rrtmg_lw_pre.F90 > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-8b264aa21ff40c4429898c0ee186f1d250c134d1c51081ccf57d53287bfde5ec > > > > > (2) > > > - *M* physics/rrtmg_sw_pre.F90 > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-5b24b437c49265bcc9ea71fafd706ee5dc56af478fc8bcb529a59bc21d8575bb > > > > > (2) > > > - *M* physics/rrtmg_sw_pre.meta > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-0c5b7ebe707da2e956d1603992b3c8bbe94b675cc12524a03f79ef3e552a14af > > > > > (2) > > > - *M* physics/rrtmgp_lw_pre.F90 > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-57c7ce7bb915bfd15a5199eccc2db14c8aba1740702b41c032ac16b0b626882c > > > > > (2) > > > - *M* physics/rrtmgp_lw_pre.meta > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-4b56a678cf27711f8156c72b114d694260b52950a75c138de4433031c6785f78 > > > > > (2) > > > - *M* physics/scm_sfc_flux_spec.F90 > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-a0ad5decd3b1913f155bb5c561032492a2ce02dc12b2953ef8742742e0d232bf > > > > > (7) > > > - *M* physics/scm_sfc_flux_spec.meta > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-07a9995773afbc56104ca1ba00e68bc2902badb2defa9cce76855bd630df38d2 > > > > > (17) > > > - *M* physics/sfc_drv_ruc.F90 > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-efa51899be6f56b83d8739a50a18ebc321ba29e02724715f33674076c4c8ecf5 > > > > > (108) > > > - *M* physics/sfc_drv_ruc.meta > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-4430a0cba7a4613fc04316e7849e79992903e316ed53b8dc768f1ada4601d270 > > > > > (18) > > > - *M* physics/sfc_noah_wrfv4_interstitial.F90 > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-1fe92104ed4d211296bbaa271f58c5582eeea0bc1a422d574ecb9514c01ce6e7 > > > > > (5) > > > - *M* physics/sfc_noah_wrfv4_interstitial.meta > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-5d5b94b0f2bc54889c0f74d5b4ab7fccde3708a6bccbc1816b15ec8f275e8828 > > > > > (5) > > > - *M* physics/sfcsub.F > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-0a719caf5556adb1de966a49cb3932aa1ed4db107e82ad7c6621e4991c72caeb > > > > > (2) > > > - *M* physics/ugwpv1_gsldrag.F90 > > > < > https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3/files#diff-566ce8850b376476624d893e854508228b09fab258a632d6ae86137f4c5398c6 > > > > > (5) > > > > > > Patch Links: > > > > > > - https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3.patch > > > - https://github.com/AnningCheng-NOAA/ccpp-physics/pull/3.diff > > > > > > — > > > You are receiving this because you were mentioned. > > > Reply to this email directly, view it on GitHub > > > <#3>, or > unsubscribe > > > < > https://github.com/notifications/unsubscribe-auth/ALQPMIK5EYMYZ7EZREYTUIDUFSS5LANCNFSM5FPR4CBA > > > > > . > > > Triage notifications on the go with GitHub Mobile for iOS > > > < > https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 > > > > > or Android > > > < > https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub > >. > > > > > > > > — > > You are receiving this because you authored the thread. > > Reply to this email directly, view it on GitHub < > #3 (comment)>, > or unsubscribe < > https://github.com/notifications/unsubscribe-auth/AB5C2ROKR4PPGE37PKY6DF3UFWUVPANCNFSM5FPR4CBA > >. > > Triage notifications on the go with GitHub Mobile for iOS < > https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android < > https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > > > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#3 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ALQPMIKOXWUBXVJRT5WU5ETUFW5Q3ANCNFSM5FPR4CBA> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2RPVSY3UATXNXFXIJB3UFXZW3ANCNFSM5FPR4CBA>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.