scnv_interstitial update#121
Merged
Merged
Conversation
…nv and samfdeepcnv, respectively; updates to samfshalcnv-specific interstitial and generic shallow convection interstitial
grantfirl
added
work in progress
do not merge
and removed
do not merge
work in progress
labels
grantfirl
force-pushed
the
SCNV_interstitial
branch
from
021a33f to
f65b9f1
Compare
Collaborator
|
Somehow my commit on the stochastic physics shows up in your commit list. Could you try to get rid of it by pulling in the latest master branch? If you take a backup beforehand and a graphical diff afterwards shows no differences, then you can safely push the updated version w/o having to rerun the tests. |
climbfuji
approved these changes
Jul 21, 2018
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Approved, would be a nice to have to get rid of the commits that are already in master.
Collaborator
Author
|
I think that I need to back away from the computer. :) I think that I squashed your commit in with one from this PR. Since it's already pushed to github, I'm not really sure how to undo this. I have the original branch (before rebasing) on Theia that I can try to fix this with. |
grantfirl
force-pushed
the
SCNV_interstitial
branch
from
5d35c15 to
021a33f
Compare
grantfirl
force-pushed
the
SCNV_interstitial
branch
from
021a33f to
aaf168a
Compare
Collaborator
Author
|
OK, that worked. I redid the rebase of the last few debugging commits on Theia and pushed it in. It is the exact same code that was tested. |
Collaborator
|
Thanks! |
SamuelTrahanNOAA
added a commit
to SamuelTrahanNOAA/ccpp-physics
that referenced
this pull request
Feb 23, 2022
Updates to MYNN-EDMF, part I - goes with other PR for fv3atm
Overview of changes:
This commit should be considered step one of the "universalization" process to generalize module_bl_mynn.F90 both for all dycores. Much of this is strictly reformatting or repositioning the driver to the top of the module - a request from collaborators, but some of it involve removing ifdefs, and the handling of the model constants. More commits to complete this work will follow. Despite the huge number of lines changed from this work alone, there is no change in behavior/performance.
fixed some old crash cases (improved numerical stability)
conservation work - removes all negative qv printouts
A bug fix for the interpolation of the mass-flux clouds from interface levels to mid-levels which cause excessive LWP in shallow-cumulus fields
Removes a few unused variables/arrays
Fixes for the smoke/chemical mixing (works but still not in final state - another commit will follow)
Some tuning work to improve the excessive cloud bias in polar regions.
Some tuning of the mass-flux component to improve the tropics.
General clean up of code and updates to many comments.
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Aug 3, 2022
* Updates to MYNN-EDMF, part II - goes with mods for ccpp-physics * updating default mixing length option to 1 * Changing eq to eqv for logical if-then tests. * Removing .eq. and .eqv. from logical if-then tests. * point to top of gsl/develop for ccpp/physics Co-authored-by: Samuel Trahan <Samuel.Trahan@noaa.gov>
SamuelTrahanNOAA
added a commit
to SamuelTrahanNOAA/ccpp-physics
that referenced
this pull request
Nov 8, 2023
SamuelTrahanNOAA
pushed a commit
to SamuelTrahanNOAA/ccpp-physics
that referenced
this pull request
Nov 9, 2023
Add a condition to turn off samfdeepcnv when MYNN shallow convection active
lisa-bengtsson
added a commit
to lisa-bengtsson/ccpp-physics
that referenced
this pull request
Nov 9, 2023
Merge PR NCAR#121 and resolve conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removed mfdeepcnv and mfshalcnv since they were replaced by samfshalcnv and samfdeepcnv, respectively; updates to samfshalcnv-specific interstitial and generic shallow convection interstitial