sfcsub.F land-mask bug fix#721
Merged
Conversation
(slmskl is not '1'). Fixes #719.
GeorgeGayno-NOAA
requested review from
JulieSchramm,
climbfuji,
grantfirl and
llpcarson
as code owners
climbfuji
reviewed
Aug 23, 2021
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Simple and straightforward. We will need to get this in as soon as possible, if necessary combine it with other ufs-weather-model changes. Will approve once the code has passed the regression tests.
climbfuji
approved these changes
Sep 2, 2021
junwang-noaa
pushed a commit
to NOAA-EMC/ufsatm
that referenced
this pull request
Sep 3, 2021
1. changes in NCAR/ccpp-physics#721 (sfcsub.F land-mask bug fix)
JohanaRomeroAlvarez
pushed a commit
to JohanaRomeroAlvarez/ccpp-physics
that referenced
this pull request
Sep 8, 2025
* add 5 ccpp SDFs in support of RRFS ensemble * add one more ccpp SDF for RRFS fire weather application by removing GWD in FV3_HRRR_gf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update a sea ice loop in sfcsub.F to only operate at non-land points (slmskl /= 1).
This fix was tested using the UFS_UTILS
global_cycleprogram. That program is essentially a wrapper around the sfcsub.F module. Tested successfully using a canned C768 global case.For more details, see #719 and ufs-community/UFS_UTILS#549 (comment)