-
Notifications
You must be signed in to change notification settings - Fork 358
Conversation
bf49040
to
61f9fcf
Compare
61f9fcf
to
a0e1633
Compare
@coryb there is now parity across the methods in the Prompt interface. Not sure why I wanted to avoid another file in the root of the project when there are already so many... |
I thought a bit more about this API and i think one of two things needs to happen. Either I should remove Any preference @coryb? Keeping it in the EDIT: I decided to go with removing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, I agree with the HelpInput change and moving the Icons to the Config struct.
* updated readme * added ask opt to set help input rune * removed global icon definitions * templates refer to icon field * added explicit icon sets to tests * added missing icon set in test runner * removed errant log * added missing icon set in select test * added WithIconSet AskOpt * can set error icon * Prompt interface now uses PromptConfig * tests use default icon set instead of hardcoded value * config comes first in prompt inteface * ran gofmt * renamed WithHelpInputRune to WithHelpInput * removed HelpInput from icon set * removed unnecessary type cast * removed globally defined default icon set * added AskOpt to set default filter * documented WithFilter * renamed WithIconSet to WithIcons
Have been disabled since AlecAivazis#216. Co-authored-by: Boris Od <[email protected]>
* Re-enable `TestAsk` tests. Have been disabled since #216. Co-authored-by: Boris Od <[email protected]> * TestAsk: ensure `vi` is used in Editor tests Co-authored-by: Boris Od <[email protected]>
This PR continues the work in #201 and adds the remaining
AskOpts
:survey.WithHelpInput
to change the rune that prompts look for to provide help.survey.WithIcons
to change the iconssurvey.WithFilter
to change the default filter applied to Select/MultiSelectThis has to go in after #214 since it relies on the
PromptConfig
which was introduced it that PR.