Skip to content
This repository was archived by the owner on Apr 19, 2024. It is now read-only.

Remove config via global variable #201

Closed
5 tasks done
AlecAivazis opened this issue May 28, 2019 · 4 comments
Closed
5 tasks done

Remove config via global variable #201

AlecAivazis opened this issue May 28, 2019 · 4 comments
Milestone

Comments

@AlecAivazis
Copy link
Owner

AlecAivazis commented May 28, 2019

Branching off of the conversation in #192, we should see if we can use variadic configuration functions to remove as much configuration via global variables as possible.

The things we should consider removing from global config:

  • Validators to AskOne
  • Icon Text
  • Help input rune
  • PageSize
  • Default filter
@ahmetb
Copy link
Contributor

ahmetb commented May 31, 2019

+PageSize

@AlecAivazis
Copy link
Owner Author

@ahmetb thanks for the suggestion! I'm curious if that was because you think there is a better default? I pulled 7 out of nowhere so if you have any reason for a particular number, i'd love to hear it

@ahmetb
Copy link
Contributor

ahmetb commented May 31, 2019

I don't need a better default. :) I just need to configure it per-question.

@AlecAivazis
Copy link
Owner Author

Well you can already configure it per prompt by setting the PageSize field on the Select and MultiSelect structs but I'm adding the ability to set it with an AskOpt now

This was referenced May 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants