Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

Re-enable TestAsk #354

Merged
merged 2 commits into from
May 12, 2021
Merged

Re-enable TestAsk #354

merged 2 commits into from
May 12, 2021

Conversation

cben
Copy link
Contributor

@cben cben commented May 11, 2021

Those got disabled in https://github.com/AlecAivazis/survey/pull/216/files#diff-3a029c8ea50304c9dc5637560df2375bc28f1620d72744a13f4d3c152bb16a4aR120 and apparently were forgotten since then?

I noticed several tests, some here and some in other files, sometimes get stuck when running go test -v.
Everything works reliably without -v, so I guess there are timing issues due to verbose printing; but when focusing on a single test with -run=REGEXP they also work pretty reliably even with -v.

  • Exception: I kept the "What days do you prefer" test commented out because it always gets stuck, with or without -v, and I don't know how to debug it (-v doesn't help — it doesn't get to show "raw output" which is usually very helpful).

@cben cben force-pushed the enable-TestAsk branch from 218bd91 to 4f2841d Compare May 11, 2021 15:40
@cben
Copy link
Contributor Author

cben commented May 12, 2021

@AlecAivazis please review.

@AlecAivazis
Copy link
Owner

Thanks for hunting this down @cben!

@AlecAivazis AlecAivazis merged commit 60ad3ef into AlecAivazis:master May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants