Skip to content

Conversation

@ermalkaleci
Copy link
Contributor

No description provided.

@ermalkaleci
Copy link
Contributor Author

/bench evm

@ghost
Copy link

ghost commented Apr 3, 2022

Finished benchmark for branch: precompile_rebench

Benchmark: EVM

make bench-evm

Results

cargo bench -p runtime-common --features bench | cargo run --bin weight-gen -- --template ./templates/precompile-weight-template.hbs --output runtime/common/src/precompile/weights.rs

@codecov
Copy link

codecov bot commented Apr 3, 2022

Codecov Report

Merging #2020 (22b5e4c) into master (ebb91df) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2020      +/-   ##
==========================================
- Coverage   86.29%   86.24%   -0.06%     
==========================================
  Files          99       99              
  Lines       20151    19845     -306     
==========================================
- Hits        17390    17115     -275     
+ Misses       2761     2730      -31     
Impacted Files Coverage Δ
modules/currencies/src/tests.rs
modules/currencies/src/lib.rs
modules/nft/src/lib.rs 74.85% <0.00%> (ø)
modules/nft/src/tests.rs 99.75% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebb91df...22b5e4c. Read the comment docs.

@ermalkaleci
Copy link
Contributor Author

/bench evm

@ghost
Copy link

ghost commented Apr 3, 2022

Finished benchmark for branch: precompile_rebench

Benchmark: EVM

make bench-evm

Results

cargo bench -p runtime-common --features bench | cargo run --bin weight-gen -- --template ./templates/precompile-weight-template.hbs --output runtime/common/src/precompile/weights.rs

Weights file runtime/common/src/precompile/weights.rs was generated.
cargo bench -p module-evm --features bench | evm-bench/analyze_benches.js runtime/common/src/gas_to_weight_ratio.rs
┌─────────┬───────────────────────┬───────┬────────┬────────────┬──────────────┬──────────┬───────┐
│ (index) │ name │ reads │ writes │ weight │ total_weight │ used_gas │ ratio │
├─────────┼───────────────────────┼───────┼────────┼────────────┼──────────────┼──────────┼───────┤
│ 0 │ 'erc20_transfer' │ 2 │ 2 │ 201978000 │ 451978000 │ 52082 │ 8678 │
│ 1 │ 'ballot_vote' │ 5 │ 3 │ 227957000 │ 652957000 │ 75812 │ 8612 │
│ 2 │ 'ballot_delegate' │ 4 │ 2 │ 209151000 │ 509151000 │ 74340 │ 6848 │
│ 3 │ 'erc20_transfer_many' │ 101 │ 101 │ 6796130000 │ 19421130000 │ 2856492 │ 6798 │
│ 4 │ 'erc20_approve_many' │ 100 │ 100 │ 4390472000 │ 16890472000 │ 2511136 │ 6726 │
│ 5 │ 'erc20_approve' │ 1 │ 1 │ 182569000 │ 307569000 │ 46593 │ 6601 │
│ 6 │ 'storage_store_many' │ 101 │ 101 │ 3734436000 │ 16359436000 │ 2581277 │ 6337 │
│ 7 │ 'storage_store' │ 1 │ 1 │ 124158000 │ 249158000 │ 43724 │ 5698 │
│ 8 │ 'empty_noop' │ 0 │ 0 │ 57069000 │ 57069000 │ 21186 │ 2693 │
│ 9 │ 'empty_deploy' │ 0 │ 0 │ 119339000 │ 119339000 │ 76975 │ 1550 │
│ 10 │ 'ballot_deploy' │ 5 │ 5 │ 282835000 │ 907835000 │ 1060480 │ 856 │
│ 11 │ 'storage_deploy' │ 0 │ 0 │ 134311000 │ 134311000 │ 187075 │ 717 │
│ 12 │ 'erc20_deploy' │ 4 │ 4 │ 317735000 │ 817735000 │ 1338700 │ 610 │
└─────────┴───────────────────────┴───────┴────────┴────────────┴──────────────┴──────────┴───────┘
Ratio 9000

@ermalkaleci ermalkaleci marked this pull request as ready for review April 3, 2022 19:39
@ermalkaleci ermalkaleci requested review from xlc and zjb0807 April 3, 2022 19:39
@ermalkaleci ermalkaleci enabled auto-merge (squash) April 3, 2022 21:02
@ermalkaleci ermalkaleci merged commit bca63c0 into master Apr 3, 2022
@ermalkaleci ermalkaleci deleted the precompile_rebench branch April 3, 2022 21:14
syan095 pushed a commit that referenced this pull request Apr 8, 2022
…ts-for-currencies

* origin/master: (362 commits)
  Skip idle_scheduler Calls When Not Producing blocks  (#1721)
  config more homa subaccounts for Karura (#2004)
  rm wt storage (#1984)
  Update construct_runtime's syntax (#2000)
  polkadot v0.9.18 (#1988)
  be srtool compatible (#2021)
  Update README.md (#2022)
  update precompile weights (#2020)
  Mandala supports PricingPegged for taiKSM (#2015)
  remove unneeded param (#2014)
  fix srtool (#2013)
  update precompile gas_limit (#2007)
  fix verify bootnodes script
  Bump minimist from 1.2.5 to 1.2.6 in /ts-tests (#2008)
  Bump (#2005)
  add NativeAssetId to asset registry (#1993)
  connect earning and incentives (#1995)
  Liquidation (#1955)
  Improvement/orml oracle (#1998)
  Mock xcm (#1977)
  ...

# Conflicts:
#	modules/currencies/src/lib.rs
#	predeploy-contracts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants