Skip to content

Conversation

@zjb0807
Copy link
Contributor

@zjb0807 zjb0807 commented Apr 1, 2022

No description provided.

@zjb0807 zjb0807 requested a review from xlc April 1, 2022 03:51
@xlc
Copy link
Member

xlc commented Apr 1, 2022

why our CI didn't catch this? it should be using the same version of Rust as srtool?

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #2013 (ad12ccd) into master (36eb469) will increase coverage by 0.48%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2013      +/-   ##
==========================================
+ Coverage   86.06%   86.55%   +0.48%     
==========================================
  Files          97      100       +3     
  Lines       19262    20714    +1452     
==========================================
+ Hits        16577    17928    +1351     
- Misses       2685     2786     +101     
Impacted Files Coverage Δ
rpc/src/lib.rs
modules/nft/src/lib.rs 74.85% <0.00%> (ø)
modules/currencies/src/tests.rs 100.00% <0.00%> (ø)
modules/currencies/src/lib.rs 80.10% <0.00%> (ø)
modules/nft/src/tests.rs 99.75% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36eb469...ad12ccd. Read the comment docs.

@zjb0807
Copy link
Contributor Author

zjb0807 commented Apr 1, 2022

We are using 1.58 to support rust 2021.
The srtool is not upgraded so the polkadot is not supporting rust 2021

rustc 1.58.0-nightly (072799443 2021-11-06)

We should push the srtool upgrade

@zjb0807 zjb0807 enabled auto-merge (squash) April 1, 2022 04:33
@zjb0807 zjb0807 merged commit 3d15991 into master Apr 1, 2022
@zjb0807 zjb0807 deleted the fix-srtool branch April 1, 2022 05:05
syan095 pushed a commit that referenced this pull request Apr 8, 2022
…ts-for-currencies

* origin/master: (362 commits)
  Skip idle_scheduler Calls When Not Producing blocks  (#1721)
  config more homa subaccounts for Karura (#2004)
  rm wt storage (#1984)
  Update construct_runtime's syntax (#2000)
  polkadot v0.9.18 (#1988)
  be srtool compatible (#2021)
  Update README.md (#2022)
  update precompile weights (#2020)
  Mandala supports PricingPegged for taiKSM (#2015)
  remove unneeded param (#2014)
  fix srtool (#2013)
  update precompile gas_limit (#2007)
  fix verify bootnodes script
  Bump minimist from 1.2.5 to 1.2.6 in /ts-tests (#2008)
  Bump (#2005)
  add NativeAssetId to asset registry (#1993)
  connect earning and incentives (#1995)
  Liquidation (#1955)
  Improvement/orml oracle (#1998)
  Mock xcm (#1977)
  ...

# Conflicts:
#	modules/currencies/src/lib.rs
#	predeploy-contracts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants