Skip to content

Conversation

@xlc
Copy link
Member

@xlc xlc commented Mar 25, 2022

Will only enable it for Mandala for now.
Also updated the OnUpdateLoan to use add/remove share instead of set share. Need to verify if this is ok.

TODOs:

  • tests

@codecov
Copy link

codecov bot commented Mar 27, 2022

Codecov Report

Merging #1995 (7e29b59) into master (c61cef9) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1995      +/-   ##
==========================================
+ Coverage   86.04%   86.23%   +0.18%     
==========================================
  Files          96       99       +3     
  Lines       18995    19950     +955     
==========================================
+ Hits        16344    17203     +859     
- Misses       2651     2747      +96     
Impacted Files Coverage Δ
modules/incentives/src/lib.rs 82.38% <100.00%> (+0.42%) ⬆️
modules/incentives/src/tests.rs 100.00% <100.00%> (ø)
modules/currencies/src/tests.rs 100.00% <0.00%> (ø)
modules/currencies/src/lib.rs 80.10% <0.00%> (ø)
rpc/src/lib.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c61cef9...7e29b59. Read the comment docs.

wangjj9219
wangjj9219 previously approved these changes Mar 28, 2022
ferrell-code
ferrell-code previously approved these changes Mar 29, 2022
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xlc xlc dismissed stale reviews from ferrell-code and wangjj9219 via 7e29b59 March 30, 2022 00:23
@xlc xlc enabled auto-merge (squash) March 30, 2022 01:10
@xlc xlc merged commit 36613a3 into master Mar 30, 2022
@xlc xlc deleted the earning-incentives branch March 30, 2022 01:44
syan095 pushed a commit that referenced this pull request Apr 8, 2022
…ts-for-currencies

* origin/master: (362 commits)
  Skip idle_scheduler Calls When Not Producing blocks  (#1721)
  config more homa subaccounts for Karura (#2004)
  rm wt storage (#1984)
  Update construct_runtime's syntax (#2000)
  polkadot v0.9.18 (#1988)
  be srtool compatible (#2021)
  Update README.md (#2022)
  update precompile weights (#2020)
  Mandala supports PricingPegged for taiKSM (#2015)
  remove unneeded param (#2014)
  fix srtool (#2013)
  update precompile gas_limit (#2007)
  fix verify bootnodes script
  Bump minimist from 1.2.5 to 1.2.6 in /ts-tests (#2008)
  Bump (#2005)
  add NativeAssetId to asset registry (#1993)
  connect earning and incentives (#1995)
  Liquidation (#1955)
  Improvement/orml oracle (#1998)
  Mock xcm (#1977)
  ...

# Conflicts:
#	modules/currencies/src/lib.rs
#	predeploy-contracts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants