Fix calculation #1935
Merged
Fix calculation #1935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1935 +/- ##
==========================================
- Coverage 85.87% 85.51% -0.37%
==========================================
Files 90 89 -1
Lines 19340 18475 -865
==========================================
- Hits 16608 15798 -810
+ Misses 2732 2677 -55
Continue to review full report at Codecov.
|
syan095
pushed a commit
that referenced
this pull request
Mar 8, 2022
…count * origin/master: (21 commits) udpate predeploy and disable NFT precompile for karura & acala (#1942) remove old migrations (#1937) Optimized calculations t avoid error caused by division missing (#1935) Statemine integration test (#1712) switch to london (#1932) fix clap annotation (#1933) fix package name (#1928) type cleanup (#1931) bump version (#1930) V0.9.17 (#1924) update precompile set (#1929) bump version (#1926) use internal release for dev release fix evm-bench access_list (#1925) add missing precompiles and fixes (#1923) remove legacy trader location (#1920) cdp enhancement (#1886) add new call to execute completely fast match redeem (#1922) Change StorageDepositPerByte (#1919) add ACA to CollateralCurrencyIds (#1918) ... # Conflicts: # Cargo.lock # orml # runtime/integration-tests/src/setup.rs # runtime/integration-tests/src/stable_asset.rs # runtime/mandala/Cargo.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
debit_value / exchange_rate = debit_balance, but debit_balance * exchange_rate may be 1 smaller than debit_value. So need fix calculation to resolve possible repaid debit failure.