Skip to content

Conversation

@ermalkaleci
Copy link
Contributor

@ermalkaleci ermalkaleci commented Mar 2, 2022

No description provided.

@ermalkaleci ermalkaleci requested review from xlc and zjb0807 March 2, 2022 13:11
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #1932 (bd31408) into master (a593da0) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

❗ Current head bd31408 differs from pull request most recent head 449a808. Consider uploading reports for the commit 449a808 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1932      +/-   ##
==========================================
- Coverage   86.21%   86.07%   -0.15%     
==========================================
  Files          91       89       -2     
  Lines       19813    18923     -890     
==========================================
- Hits        17082    16288     -794     
+ Misses       2731     2635      -96     
Impacted Files Coverage Δ
modules/evm/src/lib.rs 65.03% <ø> (ø)
modules/evm/src/tests.rs 99.26% <100.00%> (ø)
modules/currencies/src/tests.rs
modules/currencies/src/lib.rs
modules/evm/src/runner/stack.rs 58.13% <0.00%> (+0.25%) ⬆️
modules/evm/src/runner/state.rs 51.47% <0.00%> (+3.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a593da0...449a808. Read the comment docs.

@ermalkaleci ermalkaleci marked this pull request as ready for review March 2, 2022 19:32
xlc
xlc previously approved these changes Mar 2, 2022
@ermalkaleci
Copy link
Contributor Author

/bench evm

@ghost
Copy link

ghost commented Mar 2, 2022

Error running benchmark: switch_evm_london

stdoutfatal: failed to unpack tree object 1a0a4029b90b0c781eb448e8686f8818c69b4e98 error: Submodule 'predeploy-contracts' could not be updated. error: Submodule 'predeploy-contracts' cannot checkout new HEAD. fatal: Could not reset index file to revision 'origin/switch_evm_london'.

@ermalkaleci
Copy link
Contributor Author

/bench clean

@ghost
Copy link

ghost commented Mar 2, 2022

Clean done

@ermalkaleci
Copy link
Contributor Author

/bench evm

@ghost
Copy link

ghost commented Mar 2, 2022

Error running benchmark: switch_evm_london

stdoutfatal: failed to unpack tree object 1a0a4029b90b0c781eb448e8686f8818c69b4e98 error: Submodule 'predeploy-contracts' could not be updated. error: Submodule 'predeploy-contracts' cannot checkout new HEAD. fatal: Could not reset index file to revision 'origin/switch_evm_london'.

@ermalkaleci
Copy link
Contributor Author

/bench evm

@ghost
Copy link

ghost commented Mar 2, 2022

Error running benchmark: switch_evm_london

stdoutfatal: failed to unpack tree object 1a0a4029b90b0c781eb448e8686f8818c69b4e98 error: Submodule 'predeploy-contracts' could not be updated. error: Submodule 'predeploy-contracts' cannot checkout new HEAD. fatal: Could not reset index file to revision 'origin/switch_evm_london'.

@ermalkaleci
Copy link
Contributor Author

/bench evm

@ghost
Copy link

ghost commented Mar 2, 2022

Finished benchmark for branch: switch_evm_london

Benchmark: EVM

make bench-evm

Results

cargo bench -p module-evm --features bench | evm-bench/analyze_benches.js runtime/common/src/gas_to_weight_ratio.rs
┌─────────┬───────────────────────┬───────┬────────┬────────────┬──────────────┬──────────┬───────┐
│ (index) │ name │ reads │ writes │ weight │ total_weight │ used_gas │ ratio │
├─────────┼───────────────────────┼───────┼────────┼────────────┼──────────────┼──────────┼───────┤
│ 0 │ 'erc20_transfer' │ 2 │ 2 │ 202249000 │ 452249000 │ 52082 │ 8683 │
│ 1 │ 'ballot_vote' │ 5 │ 3 │ 215036000 │ 640036000 │ 75812 │ 8442 │
│ 2 │ 'ballot_delegate' │ 4 │ 2 │ 213804000 │ 513804000 │ 74340 │ 6911 │
│ 3 │ 'erc20_transfer_many' │ 101 │ 101 │ 6697562000 │ 19322562000 │ 2856492 │ 6764 │
│ 4 │ 'erc20_approve_many' │ 100 │ 100 │ 4395231000 │ 16895231000 │ 2511136 │ 6728 │
│ 5 │ 'storage_store_many' │ 101 │ 101 │ 3743523000 │ 16368523000 │ 2581277 │ 6341 │
│ 6 │ 'erc20_approve' │ 1 │ 1 │ 168735000 │ 293735000 │ 46593 │ 6304 │
│ 7 │ 'storage_store' │ 1 │ 1 │ 124021000 │ 249021000 │ 43724 │ 5695 │
│ 8 │ 'empty_noop' │ 0 │ 0 │ 53187000 │ 53187000 │ 21186 │ 2510 │
│ 9 │ 'empty_deploy' │ 0 │ 0 │ 121014000 │ 121014000 │ 76975 │ 1572 │
│ 10 │ 'ballot_deploy' │ 5 │ 5 │ 276741000 │ 901741000 │ 1060480 │ 850 │
│ 11 │ 'storage_deploy' │ 0 │ 0 │ 124836000 │ 124836000 │ 187075 │ 667 │
│ 12 │ 'erc20_deploy' │ 4 │ 4 │ 314829000 │ 814829000 │ 1338700 │ 608 │
└─────────┴───────────────────────┴───────┴────────┴────────────┴──────────────┴──────────┴───────┘
Ratio 8683

zjb0807
zjb0807 previously approved these changes Mar 2, 2022
@ermalkaleci ermalkaleci merged commit 868ea79 into master Mar 3, 2022
@ermalkaleci ermalkaleci deleted the switch_evm_london branch March 3, 2022 09:40
syan095 pushed a commit that referenced this pull request Mar 8, 2022
…count

* origin/master: (21 commits)
  udpate predeploy and disable NFT precompile for karura & acala (#1942)
  remove old migrations (#1937)
  Optimized calculations t avoid error caused by division missing (#1935)
  Statemine integration test (#1712)
  switch to london (#1932)
  fix clap annotation (#1933)
  fix package name (#1928)
  type cleanup (#1931)
  bump version (#1930)
  V0.9.17 (#1924)
  update precompile set (#1929)
  bump version (#1926)
  use internal release for dev release
  fix evm-bench access_list (#1925)
  add missing precompiles and fixes (#1923)
  remove legacy trader location (#1920)
  cdp enhancement (#1886)
  add new call to execute completely fast match redeem (#1922)
  Change StorageDepositPerByte (#1919)
  add ACA to CollateralCurrencyIds (#1918)
  ...

# Conflicts:
#	Cargo.lock
#	orml
#	runtime/integration-tests/src/setup.rs
#	runtime/integration-tests/src/stable_asset.rs
#	runtime/mandala/Cargo.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants