Skip to content

Conversation

@ermalkaleci
Copy link
Contributor

No description provided.

@ermalkaleci ermalkaleci requested a review from zjb0807 February 24, 2022 12:23
@ermalkaleci ermalkaleci linked an issue Feb 24, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #1923 (12f09b4) into master (01c72e8) will increase coverage by 0.21%.
The diff coverage is 83.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1923      +/-   ##
==========================================
+ Coverage   85.65%   85.87%   +0.21%     
==========================================
  Files          80       90      +10     
  Lines       18110    19336    +1226     
==========================================
+ Hits        15512    16604    +1092     
- Misses       2598     2732     +134     
Impacted Files Coverage Δ
modules/evm/src/precompiles/ecrecover_publickey.rs 0.00% <0.00%> (ø)
modules/evm/src/precompiles/identity.rs 0.00% <0.00%> (ø)
modules/evm/src/precompiles/mod.rs 0.00% <0.00%> (ø)
modules/evm/src/precompiles/ripemd.rs 0.00% <0.00%> (ø)
modules/evm/src/precompiles/sha256.rs 0.00% <0.00%> (ø)
modules/evm/src/precompiles/bn128.rs 70.83% <70.83%> (ø)
modules/evm/src/precompiles/sha3fips.rs 84.31% <84.31%> (ø)
modules/evm/src/precompiles/modexp.rs 96.51% <96.51%> (ø)
modules/evm/src/precompiles/blake2/eip_152.rs 96.55% <96.55%> (ø)
modules/evm/src/precompiles/blake2/mod.rs 96.73% <96.73%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01c72e8...12f09b4. Read the comment docs.

@ermalkaleci ermalkaleci marked this pull request as draft February 24, 2022 16:55
@ermalkaleci ermalkaleci marked this pull request as ready for review February 26, 2022 07:38
@ermalkaleci ermalkaleci requested a review from xlc February 26, 2022 07:39
Copy link
Contributor

@zjb0807 zjb0807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xlc xlc merged commit 94b5426 into master Feb 27, 2022
@xlc xlc deleted the new_precompiles branch February 27, 2022 02:12
syan095 pushed a commit that referenced this pull request Mar 8, 2022
…count

* origin/master: (21 commits)
  udpate predeploy and disable NFT precompile for karura & acala (#1942)
  remove old migrations (#1937)
  Optimized calculations t avoid error caused by division missing (#1935)
  Statemine integration test (#1712)
  switch to london (#1932)
  fix clap annotation (#1933)
  fix package name (#1928)
  type cleanup (#1931)
  bump version (#1930)
  V0.9.17 (#1924)
  update precompile set (#1929)
  bump version (#1926)
  use internal release for dev release
  fix evm-bench access_list (#1925)
  add missing precompiles and fixes (#1923)
  remove legacy trader location (#1920)
  cdp enhancement (#1886)
  add new call to execute completely fast match redeem (#1922)
  Change StorageDepositPerByte (#1919)
  add ACA to CollateralCurrencyIds (#1918)
  ...

# Conflicts:
#	Cargo.lock
#	orml
#	runtime/integration-tests/src/setup.rs
#	runtime/integration-tests/src/stable_asset.rs
#	runtime/mandala/Cargo.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing precompiles

4 participants