Skip to content

add newton step convergence checks to steadystate solver #1737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Mar 25, 2022
Merged

add newton step convergence checks to steadystate solver #1737

merged 19 commits into from
Mar 25, 2022

Conversation

FFroehlich
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Mar 19, 2022 •
edited
Loading

Codecov Report

Merging #1737 (633e899) into develop (e6980ad) will decrease coverage by 0.86%.
The diff coverage is 73.78%.

❗ Current head 633e899 differs from pull request most recent head 6080d53. Consider uploading reports for the commit 6080d53 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1737      +/-   ##
===========================================
- Coverage    78.81%   77.95%   -0.87%     
===========================================
  Files           69       73       +4     
  Lines        10717    11420     +703     
===========================================
+ Hits          8447     8902     +455     
- Misses        2270     2518     +248
Flag Coverage Δ
cpp 74.90% <84.61%> (-0.44%) ⬇️
petab 62.51% <44.92%> (-4.18%) ⬇️
python 68.20% <72.91%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/amici/abstract_model.h 0.00% <ø> (ø)
include/amici/model.h 60.86% <ø> (ø)
include/amici/rdata.h 94.44% <ø> (ø)
python/amici/numpy.py 82.60% <ø> (ø)
python/amici/pandas.py 98.25% <ø> (ø)
src/abstract_model.cpp 4.06% <ø> (-1.09%) ⬇️
src/backwardproblem.cpp 63.73% <ø> (ø)
src/hdf5.cpp 90.68% <ø> (+1.01%) ⬆️
src/model.cpp 86.02% <ø> (+1.58%) ⬆️
src/model_ode.cpp 70.79% <ø> (-5.95%) ⬇️
... and 37 more

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@FFroehlich FFroehlich marked this pull request as ready for review March 23, 2022 14:37
@FFroehlich FFroehlich requested a review from dweindl March 23, 2022 14:37
@dweindl dweindl requested a review from plakrisenko March 23, 2022 14:40
dweindl
dweindl approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Looks good, as far as I can tell

@FFroehlich FFroehlich changed the title add newton style convergence checks to steady-state solver add newton step convergence checks to steady-state solver Mar 23, 2022
@FFroehlich FFroehlich changed the title add newton step convergence checks to steady-state solver add newton step convergence checks to steadystate solver Mar 23, 2022
@FFroehlich FFroehlich mentioned this pull request Mar 23, 2022
Closed
9 tasks
@FFroehlich FFroehlich merged commit 8d6288e into develop Mar 25, 2022
@FFroehlich FFroehlich deleted the better_steadystate_convergence branch March 25, 2022 13:52
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@FFroehlich FFroehlich mentioned this pull request Apr 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dweindl dweindl dweindl approved these changes

@plakrisenko plakrisenko Awaiting requested review from plakrisenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FFroehlich @dweindl