-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean-up steady-state solver code #1073
Labels
Milestone
Comments
Very much in favor. This is a huge pain to debug. |
Merged
I have no idea what this refers to, anyone? |
No idea. |
Started here. Might need some further updates already. |
Closing this. Addressed, except for:
Nobody seems to know what that was about. Unlikely to change.
Part of #2582 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the workSteadyStateProblem routine isn't exactly the nicest part of Amici...
Things to be changed here in some close future:
Move applyNewtonsMethod from SteadyStateProblem to NewtonSolver #1675Replace custom implementation of iterative linear solver in Newton Solver byInterface GMRES, BICGSTAB, and TFQMR (do it analogously to solver.cpp) (Use SUNLinSolWrapper in NewtonSolver #1164 )The text was updated successfully, but these errors were encountered: