Skip to content

Fix static usage of error messages that results in them being untranslated #9997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellhenke merged 1 commit into from
Feb 15, 2024
Merged

Fix static usage of error messages that results in them being untranslated #9997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/forms/openid_connect_logout_form.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@ class OpenidConnectLogoutForm

validates :client_id,
presence: {
message: I18n.t('openid_connect.logout.errors.client_id_missing'),
message: ->(_, _) { I18n.t('openid_connect.logout.errors.client_id_missing') },
},
if: :reject_id_token_hint?
validates :id_token_hint,
absence: {
message: I18n.t('openid_connect.logout.errors.id_token_hint_present'),
message: ->(_, _) { I18n.t('openid_connect.logout.errors.id_token_hint_present') },
},
if: :reject_id_token_hint?
validates :post_logout_redirect_uri, presence: true
Expand Down
2 changes: 1 addition & 1 deletion app/validators/idv/form_address_validator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ module FormAddressValidator

validates_format_of :zipcode,
with: /\A\d{5}(-?\d{4})?\z/,
message: I18n.t('idv.errors.pattern_mismatch.zipcode'),
message: ->(_, _) { I18n.t('idv.errors.pattern_mismatch.zipcode') },
allow_blank: true

validates :city, presence: true, length: { maximum: 255 }
Expand Down
2 changes: 1 addition & 1 deletion app/validators/idv/form_ssn_format_validator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ module FormSsnFormatValidator
validates :ssn, presence: true
validates_format_of :ssn,
with: /\A\d{3}-?\d{2}-?\d{4}\z/,
message: I18n.t('idv.errors.pattern_mismatch.ssn'),
message: ->(_, _) { I18n.t('idv.errors.pattern_mismatch.ssn') },
allow_blank: false
end
end
Expand Down
10 changes: 6 additions & 4 deletions app/validators/idv/form_state_id_validator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,12 @@ module FormStateIdValidator
attributes: [:dob], less_than_or_equal_to: ->(_rec) {
Time.zone.today - IdentityConfig.store.idv_min_age_years.years
},
message: I18n.t(
'in_person_proofing.form.state_id.memorable_date.errors.date_of_birth.range_min_age',
app_name: APP_NAME,
)
message: ->(_, _) do
I18n.t(
'in_person_proofing.form.state_id.memorable_date.errors.date_of_birth.range_min_age',
app_name: APP_NAME,
)
end
# rubocop:enable Layout/LineLength
end
# rubocop:enable Metrics/BlockLength
Expand Down