Merged
Conversation
* Initial draft of create-deploy-pr workflow This Github Actions workflow can be triggered manually and will create a new PR for a deployment. changelog: Internal, Deployment, Add Github Actions workflow to create deployment PRs. * Updates to create-deploy-pr - Add command line args, incl. --dry-run - Refactor some stuff out to funcs - Check for GH_TOKEN variable - Push SHA to remote directly rather than checking out local branch * Create release when deploy PR is merged * Support patch deploys * Update run-name for create-release * Move check for RC branch earlier Also technically make the check actually work * Only return merged PRs in create-release * Create release even if deploy pr is not most recent * Error out if PR not found when creating release * Remove unused command line args read
…doc` (#9913) * Stop merging things that aren't PII from the document into `pii_from_doc` The `Idv::Session#pii_from_doc` method has a name that suggests it returns the PII that is read from the document. Prior to this commit this was not the case because we merge data that was not read from the document into the `pii_from_doc` hash. This was done as a convienence so it is available when communicating to vendors in downstream steps. This commit removes the merge and provides the additional data explicitly in downsteam step. [skip changelog]
…9930) Remove app/views/idv/in_person/ssn/show.html.erb, no longer used. [skip changelog]
* LG-12036: New DocumentCaptureSessionResult attributes to separately indicates result for document check and liveness check. changelog: Internal, Doc Auth, Document capture session result attributes doc_auth_success and selfie_success. * LG-12036: documentation and test. * LG-12036: documentation and test. * LG-12036: mock client response, waiting on changes from another card. * LG-12036: update mock client response. * LG-12036: documentation change. * LG-12036: save the attributes when failure encountered. * LG-12036: address comment. * LG-12036: address comment.
changelog: Internal, Continuous Integration, Remove temporary continuous integration check on content changes
changelog: Internal, Reporting, Remove unused IRS Weekly Summary Report
* init display hint text on selfie * show error hint for selfie capture changelog: Upcoming Features, Document Authentication, Show user hints during selfie capture * attempt to display hint text in acuant capture canvas component * rendering selfie hint text * hint text is fixed on the screen Co-authored-by: Charles Ferguson <charles.ferguson@gsa.gov> * type onImageCaptureFeedback function * remove hardcode of selfie required * fix spec for hint text * happy linting * default imageCaptureText to empty string * remove quotes from i18n keys for selfie hints * Update app/javascript/packages/document-capture/components/acuant-capture.scss Co-authored-by: Charley Ferguson <charleyferguson@navapbc.com> * happy linting --------- Co-authored-by: Charles Ferguson <charles.ferguson@gsa.gov> Co-authored-by: Charley Ferguson <charleyferguson@navapbc.com>
* remove before action * move time to 2 seconds to fix flaky tests there is a disconnect with redis and the rate limiter causing the tests to be flaky if you use a 1 second difference. I also changed the verify_info_step spec to check if the user is not rate limited since it would have expired. * add changelog changelog: Internal, IdV Tests, Fix flaky verify info spec test * remove be_limited check * Bump time travel to 3 to see if that makes CI happy. * Debug prints for CI * More CI fiddling. * So much CI twiddling. * More, even. * Try forcing reload from Redis * Expire rate limiter manually --------- Co-authored-by: John Maxwell <john.maxwell@gsa.gov>
* LG-11985: remove not ready section. changelog: User-facing Improvement, Doc Auth, Remove code for not-ready survey. * LG-11985: cleanup not ready translations etc. * LG-11985: linter.
* Upgrade to Ruby 3.3.0 changelog: Internal, Ruby, Upgrade to Ruby 3.3.0 * update more gems * new image sha
[skip changelog]
* adding descriptions since this component is partner facing * changelog: User-Facing Improvements, LookBook Component, Add description to Login Button component
- Via: https://www.ruby-lang.org/en/news/2023/12/25/ruby-3-3-0-released/ * Update pry-doc to hide warning changelog: Internal, Dependencies, Update dependencies
* remove empty option because it creates a stack trace * Bug Fixes,LookBook,fix bug with empty param * changelog:Bug Fixes,LookBook,fix bug with empty param
Contributor
Author
|
(Note that the Github Actions present in 9f510e9 are not currently active) |
zachmargolis
approved these changes
Jan 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features