Github Actions workflow to do deployment paperwork#9859
Merged
Conversation
zachmargolis
reviewed
Jan 5, 2024
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
Exciting to see this taking shape!
matthinz
force-pushed
the
matthinz/create-deploy-pr-workflow
branch
from
3645054 to
e72f923
Compare
This Github Actions workflow can be triggered manually and will create a new PR for a deployment. changelog: Internal, Deployment, Add Github Actions workflow to create deployment PRs.
- Add command line args, incl. --dry-run - Refactor some stuff out to funcs - Check for GH_TOKEN variable - Push SHA to remote directly rather than checking out local branch
matthinz
force-pushed
the
matthinz/create-deploy-pr-workflow
branch
from
e72f923 to
b4b4c90
Compare
Also technically make the check actually work
matthinz
changed the title
matthinz
changed the title
aduth
approved these changes
Jan 10, 2024
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
I had some pending comments I forgot to submit 🤦 But this LGTM! Noting that I haven't had a chance to actually test it, but the code looks sensible. This seems really neat; I didn't know you could launch a parameterized workflow like this on-demand.
Contributor
Author
|
Going to land this in the interest of getting out to the relevant branches--there will be some extra work to enable Github actions on the IDP. |
This was referenced Jan 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two new Gitub Actions workflows:
create-deploy-prcreate-releaseThese workflows are meant to support our existing deployment process, automating some of the "paperwork" associated with creating deployment PRs.
create-deploy-prThis workflow is meant to be triggered manually. It:
stages/prodwith the appropriate labelcreate-releaseThis workflow will be triggered automatically after the PR created by
create-deploy-pris merged. It will create a new Github Release and an accompanying tag. The tag will be signed with the Github Actions bot GPG key (since that's who created it). The release notes will be copied from the original PR (so if you edit the change log after creating the PR, those edits should propagate over to the release).Testing
The easiest way to test this is probably to fork identity-idp and run the "Create deploy PR" workflow in your fork:
After you create your PR you can merge it, and you should end up with a new release created.
A couple of notes about branches:
mainin my fork, but I think you should be able to trigger the Create deploy pr workflow from another branch if needed.stages/prodbranch for the release to be created after merging. If they are included as part of the release, that should be enough.