Stop merging things that aren't PII from the document into pii_from_doc#9913
Merged
Stop merging things that aren't PII from the document into pii_from_doc#9913
pii_from_doc#9913Conversation
…doc` The `Idv::Session#pii_from_doc` method has a name that suggests it returns the PII that is read from the document. Prior to this commit this was not the case because we merge data that was not read from the document into the `pii_from_doc` hash. This was done as a convienence so it is available when communicating to vendors in downstream steps. This commit removes the merge and provides the additional data explicitly in downsteam step. [skip changelog]
soniaconnolly
approved these changes
Jan 16, 2024
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM. Tried it locally past VerifyInfo for both remote and in-person and it worked as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Idv::Session#pii_from_docmethod has a name that suggests it returns the PII that is read from the document. Prior to this commit this was not the case because we merge data that was not read from the document into thepii_from_dochash. This was done as a convenience so it is available when communicating to vendors in downstream steps.This commit removes the merge and provides the additional data explicitly in down steam step.