Skip to content

LG-12038: Update all_passed? to consider selfie success #9937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
night-jellyfish merged 5 commits into from
Jan 19, 2024
Merged

LG-12038: Update all_passed? to consider selfie success #9937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0f5d0ed
LG-12038: Update all_passed? to consider selfie success
dawei-nava Jan 9, 2024
a4ebeac
changelog: Internal, Doc Auth, Update all_passed? to consider selfie …
Jan 18, 2024
ee0bb9d
Rm unused param
Jan 18, 2024
1ebda18
Fix interface in method call
Jan 18, 2024
4c980d8
Condense test setup
Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/services/doc_auth/lexis_nexis/responses/true_id_response.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,8 @@ def all_passed?
transaction_status_passed? &&
true_id_product.present? &&
product_status_passed? &&
doc_auth_result_passed?
doc_auth_result_passed? &&
(@liveness_checking_enabled ? selfie_success : true)
end

def selfie_result
Expand Down
7 changes: 3 additions & 4 deletions app/services/doc_auth/mock/result_response.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,7 @@ def errors
# Error generator is not to be called when it's not failure
# allows us to test successful results
return {} if all_doc_capture_values_passing?(
doc_auth_result, id_type_supported?,
face_match_result
doc_auth_result, id_type_supported?
)

mock_args = {}
Expand Down Expand Up @@ -178,10 +177,10 @@ def doc_auth_result_from_success
end
end

def all_doc_capture_values_passing?(doc_auth_result, id_type_supported, face_match_result)
def all_doc_capture_values_passing?(doc_auth_result, id_type_supported)
doc_auth_result == 'Passed' &&
id_type_supported &&
(@selfie_check_performed ? face_match_result == 'Pass' : true)
(@selfie_check_performed ? selfie_success : true)
end

def parse_uri
Expand Down
Loading