Skip to content

Document disposable email domain analytics parameter #9912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 1 commit into from
Jan 22, 2024
Merged

Document disposable email domain analytics parameter #9912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/services/analytics_events.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4570,6 +4570,7 @@ def user_registration_cancellation(request_came_from:, **extra)
# @param [String] needs_completion_screen_reason
# @param [Array] sp_request_requested_attributes
# @param [Array] sp_session_requested_attributes
# @param [String, nil] disposable_email_domain Disposable email domain used for registration
def user_registration_complete(
ial2:,
service_provider_name:,
Expand All @@ -4578,6 +4579,7 @@ def user_registration_complete(
sp_session_requested_attributes:,
sp_request_requested_attributes: nil,
ialmax: nil,
disposable_email_domain: nil,
**extra
)
track_event(
Expand All @@ -4589,6 +4591,7 @@ def user_registration_complete(
needs_completion_screen_reason: needs_completion_screen_reason,
sp_request_requested_attributes: sp_request_requested_attributes,
sp_session_requested_attributes: sp_session_requested_attributes,
disposable_email_domain: disposable_email_domain,
**extra,
)
end
Expand Down
1 change: 1 addition & 0 deletions spec/controllers/sign_up/completions_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@
sp_request_requested_attributes: nil,
sp_session_requested_attributes: nil,
in_account_creation_flow: true,
disposable_email_domain: nil,
)
end

Expand Down