Merged
Conversation
changelog: Internal, Performance, Reduce size of application stylesheet
zachmargolis
approved these changes
Jan 5, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Removes unused utility classes from the generated stylesheet, to reduce its size.
clearfixreferences were removed in #9812.maxwwas still technically expected to be used, but the utility is actually calledmax-width(source), so the expected utility classes were not actually being output. Technically this was a regression of #8093, though the actual effect is quite minor. Discussed previously at #5989 (comment), I don't think the effect is significant enough to warrant reintroducing the utility classes.📜 Testing Plan
Verify there are no lingering references in code to
clearfixormaxw-CSS classes.