Conversation
SammySteiner
force-pushed
the
LG-5417-MFA-page-design-update
branch
from
4e63840 to
edf6944
Compare
| <span class="usa-tag pin-bottom pin-right <%= option.disabled? ? 'bg-base-light' : 'bg-info-dark' %>"> | ||
| <%= option.security_level %> | ||
| <%= image_tag(asset_url("mfa-options/#{option.type}.svg"), alt: "#{option.label} icon", class: 'usa-radio__image') %> | ||
| <div class="usa-radio__label--text tablet:padding-left-1"><%= option.label %> |
There was a problem hiding this comment.
Curious about the tablet:padding-left-1 here. Should that be incorporated into the design system component? Is it accounting for whitespace from the HTML?
There was a problem hiding this comment.
Yes, it should be incorporated into the design system component. Should I back it out here or release a patch of the design system?
There was a problem hiding this comment.
I discussed with @jmdembe and we decided to keep it in here and address in the style guide another time.
There was a problem hiding this comment.
I discussed with @jmdembe and we decided to keep it in here and address in the style guide another time.
Could you create a ticket for this to make sure it's tracked?
|
The vertical alignment of the icons looks a bit off to me at small screen sizes. Do you see this as well?
|
Yes! Thanks for that. Turns out the design system needs a few more adjustments. We discussed as a team and decided to make the changes here for now and create a separate ticket to group all these changes into the design system (and remove from here). Should be fixed now. My sandbox is now up and running and can be looked at here: https://idp.ssteiner.identitysandbox.gov/ |
|
Huh why is the release step not running.. |
SammySteiner
force-pushed
the
LG-5417-MFA-page-design-update
branch
from
1959692 to
c7dade4
Compare
**Why**: Because they're unused since #5989 changelog: Internal, Code Quality, Remove unused code
**Why**: Because they're unused since #5989 changelog: Internal, Code Quality, Remove unused code
4 participants
Why
Incorporate lessons learned from user testing MFA Setup page.
https://www.figma.com/file/ATLeAQQ6iY5CDG7X7LUfX6/LG-3948-Design%3A-Redesign-authentication-selection-page-from-create-account-page?node-id=1519%3A11550
changelog: Improvements, MFA Setup, Incorporating MFA Setup redesign (LG-5417)