Skip to content

Remove unnecessary clearfix from account page widgets#9812

Merged
aduth merged 1 commit intomainfrom
aduth-rm-clearfix-account-page
Dec 20, 2023
Merged

Remove unnecessary clearfix from account page widgets#9812
aduth merged 1 commit intomainfrom
aduth-rm-clearfix-account-page

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Dec 20, 2023

🛠 Summary of changes

Removes two instances of unnecessary clearfix, within the account page Security Key listing and Verified Information security disclosure text.

Historically, these were implemented using BassCSS grid, which uses float on individual columns. As documented, it's required to define clearfix on the column container when using BassCSS grid. In #4169, we migrated from BassCSS to USWDS for these grid layouts. The design system uses flexbox for grids and does not require a clearfix.

This is a continuation of the work in #9799 to eliminate the few remaining usages of clearfix.

📜 Testing Plan

Verify no visual regressions in display of Security Key and Verified Information widgets on account dashboard:

  1. (Prerequisite: Have an account with security key and is identity-verified)
  2. Go to http://localhost:3000
  3. Sign in
  4. Observe no collapsing content in "Security Key" listing or "Verified Information"

changelog: Internal, Code Quality, Simplify to remove unnecessary page markup
@aduth aduth requested a review from mitchellhenke December 20, 2023 15:50
@aduth aduth merged commit ce49617 into main Dec 20, 2023
@aduth aduth deleted the aduth-rm-clearfix-account-page branch December 20, 2023 17:47
@jmdembe jmdembe mentioned this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants