Remove unnecessary clearfix from account page widgets#9812
Merged
Conversation
changelog: Internal, Code Quality, Simplify to remove unnecessary page markup
zachmargolis
approved these changes
Dec 20, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Removes two instances of unnecessary
clearfix, within the account page Security Key listing and Verified Information security disclosure text.Historically, these were implemented using BassCSS grid, which uses
floaton individual columns. As documented, it's required to defineclearfixon the column container when using BassCSS grid. In #4169, we migrated from BassCSS to USWDS for these grid layouts. The design system uses flexbox for grids and does not require aclearfix.This is a continuation of the work in #9799 to eliminate the few remaining usages of
clearfix.📜 Testing Plan
Verify no visual regressions in display of Security Key and Verified Information widgets on account dashboard: