Skip to content

LG-10396 Update PII Validation for State/Territory #9797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charleyf merged 9 commits into from
Dec 21, 2023
Merged

LG-10396 Update PII Validation for State/Territory #9797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
219a7d1
Add missing territory to states list
charleyf Dec 19, 2023
1cee78b
Add state validation
charleyf Dec 19, 2023
9febdb5
changelog: User-Facing Improvements, DocAuth, Validate that state/ter…
charleyf Dec 19, 2023
470bf00
Remove length error from test
charleyf Dec 19, 2023
12f0f73
Don't add the new state/territory code
charleyf Dec 20, 2023
77f5225
Merge branch 'main' into charley/lg-10396-update-pii-validation-for-s…
charleyf Dec 20, 2023
2e4e975
Combine :jurisdiction and :state validations
charleyf Dec 20, 2023
f989a7f
Merge branch 'main' into charley/lg-10396-update-pii-validation-for-s…
charleyf Dec 20, 2023
4e33718
Merge branch 'main' into charley/lg-10396-update-pii-validation-for-s…
charleyf Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions app/forms/idv/doc_pii_form.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,16 @@ class DocPiiForm
validates_presence_of :address1, { message: proc {
I18n.t('doc_auth.errors.alerts.address_check')
} }
validates_length_of :state, { is: 2,
message: proc {
I18n.t('doc_auth.errors.general.no_liveness')
} }
validates :zipcode, format: {
with: /\A[0-9]{5}(?:-[0-9]{4})?\z/,
message: proc {
I18n.t('doc_auth.errors.general.no_liveness')
},
}

validates :jurisdiction, inclusion: { in: Idp::Constants::STATE_AND_TERRITORY_CODES,
message: proc {
I18n.t('doc_auth.errors.general.no_liveness')
} }
validates :jurisdiction, :state, inclusion: { in: Idp::Constants::STATE_AND_TERRITORY_CODES,
message: proc {
I18n.t('doc_auth.errors.general.no_liveness')
} }

attr_reader :first_name, :last_name, :dob, :address1, :state, :zipcode, :attention_with_barcode,
:jurisdiction
Expand Down
2 changes: 1 addition & 1 deletion spec/controllers/idv/image_uploads_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,7 +674,7 @@
state: [I18n.t('doc_auth.errors.general.no_liveness')],
},
error_details: {
state: { wrong_length: true },
state: { inclusion: true },
},
attention_with_barcode: false,
user_id: user.uuid,
Expand Down