Move opt in analytics to ab_test_analytics_buckets

[soniaconnolly]

🛠 Summary of changes

This is a followup to #9646 which added :opt_in_analytics_buckets to some IdV controller analytics. Move the addition to ab_test_analytics_buckets so that it gets added to all the IdV controllers, and tested in ab_test_analytics_concern_spec.rb.

OtpVerificationController didn't have ab_test_analytics_buckets, so add it in.

PersonalKeyController didn't have it either, but it also didn't have IdvStepConcern, which is being added in #9776, so leaving it alone for now to avoid unnecessary conflicts.

📜 Testing Plan

• In application.yml, set in_person_proofing_opt_in_enabled: true
• Create account, start IdV
• On How to Verify screen, choose in person proofing
• Go up to Enter Password step, do not enter password
• Check events.log, confirm that opted_in_to_in_person_proofing: is present and true
• Go back to How to Verify screen
• Choose remote proofing
• Go up to Enter Password step, do not enter password
• Check events.log, confirm that opted_in_to_in_person_proofing: is present and false
• In application.yml, set in_person_proofing_opt_in_enabled: false
• Restart server
• Go back to Agreement step
• Go forward via remote proofing to Enter Password step
• Check events.log, confirm that opted_in_to_in_person_proofing: is not present for the most recent events

[matthinz]

LGTM

[svalexander]

LGTM, thanks for doing this