Merged
Conversation
added 2 commits
December 20, 2023 12:31
Unsure why these passed so many times before merging, but perhaps the interface changed since last rebase to now.
aduth
approved these changes
Dec 20, 2023
Contributor
Author
|
Ah. It is because I did not merge in #9793. I will make sure to do a rebase over main before merging in the future, sorry folks. I have in the past and let it slip this time. |
Contributor
|
@night-jellyfish Thanks for fixing this so quickly! 👏🏻 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems I broke something with #9795.
Unsure why these passed so many times before merging, but perhaps the
interface changed since last rebase to now.
Edit: it is indeed because I did not rebase before merging. See this comment for details.