Conversation
We know you are a fraud, but we need you to acknowledge your personal key first
| end | ||
| end | ||
|
|
||
| context 'personal key already acknowledged' do |
There was a problem hiding this comment.
As noted above, I think this is a back button prevention check and it should just show the personal key rather than redirecting. Especially since the user might realize they didn't save their key after all and want to go back and look at it.
There was a problem hiding this comment.
Yeah, I think you may be right
There was a problem hiding this comment.
Thinking more about it, this would be a change from how we operate right now--we explicitly remove the personal key from the session after it's been acknowledged. So I think showing the basic "Your identity has already been verified" for now is the right call and I can capture the change in a follow up ticket
There was a problem hiding this comment.
Did you have a chance to put in this followup ticket?
…roller with FlowPolicy
matthinz
changed the title
solipet
left a comment
solipet
left a comment
There was a problem hiding this comment.
One comment about stub_verify_steps_one_and_two
|
While testing this, I found an issue that's also on main: In the in person flow, when I get to the personal key page, it will let me redirect forward to the barcode page (/verify/in_person/how_to_verify). Seems like we need to incorporate that into FlowPolicy! |
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM! Tested locally, works as described.
3 participants
🎫 Ticket
LG-11725
🛠 Summary of changes
step_infomethod to PersonalKeyController📜 Testing Plan
Provide a checklist of steps to confirm the changes.
/verify/personal_key, but are instead redirected back to where you were in the flow