Skip to content

Add missing spec assertion for password change user event #9781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 1 commit into from
Dec 18, 2023
Merged

Add missing spec assertion for password change user event #9781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions spec/controllers/users/passwords_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,16 @@
end

it 'creates a user Event for the password change' do
stub_sign_in(create(:user))
user = stub_sign_in

params = { password: 'salty new password' }
patch :update, params: { update_user_password_form: params }
params = {
password: 'salty new password',
password_confirmation: 'salty new password',
Copy link
Contributor Author

@aduth aduth Dec 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of password_confirmation here is due to some code drift where we added the requirement to enter the new password twice in #8220. Since we weren't verifying anything in this spec previous, this test never began failing when adding that requirement.

}

expect do
patch :update, params: { update_user_password_form: params }
end.to change { user.events.password_changed.size }.by 1
end

it 'sends a security event' do
Expand Down