LG11696: Associate TOTP setup fields with visual label#9704
Closed
LG11696: Associate TOTP setup fields with visual label#9704
Conversation
changelog: User-Facing Improvements, Authentication, Update accessibility related to TOTP fields
jc-gsa
force-pushed
the
LG-11696-accessibility-TOTP-setup-fields
branch
from
f2bcac8 to
e425c44
Compare
aduth
reviewed
Dec 5, 2023
Comment on lines
+23
to
+25
| attr_reader :heading_level, :heading, :id | ||
|
|
||
| def initialize(heading_level:, heading:) | ||
| def initialize(heading_level:, heading:, id: nil) |
Contributor
There was a problem hiding this comment.
Since the component root element is the list item and the other constructor attributes call out "heading" specifically, I'd expect a similar qualifier like heading_id.
Alternatively, we could adopt a pattern similar to tag_options to apply arbitrary attributes to the heading element, similar to what we do in some other components (example).
<%= content_tag(
heading_level,
heading,
**heading_options,
class: [*heading_options[:class], 'usa-process-list__heading'],
) %>
Contributor
Author
There was a problem hiding this comment.
Added heading_id. New pull request is found here #9716 (couldn't revive this one).
jc-gsa
force-pushed
the
LG-11696-accessibility-TOTP-setup-fields
branch
from
ad5071d to
ffb9b6c
Compare
jc-gsa
force-pushed
the
LG-11696-accessibility-TOTP-setup-fields
branch
from
ffb9b6c to
404bc06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG11696
(WIP)