Skip to content

LG 11479 enter backup code page title #9688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinsmaster5 merged 5 commits into from
Dec 1, 2023
Merged

LG 11479 enter backup code page title #9688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cf6ec9d
changelog: Bug Fixes, 2FA, Update backup code field label to be more …
kevinsmaster5 Nov 29, 2023
46075b4
changelog: Bug Fixes, 2FA, Update Enter your backup code page title
kevinsmaster5 Dec 1, 2023
11d6e7e
fix stray space in translated text
kevinsmaster5 Dec 1, 2023
f25e9f9
align backup code page title with h1
kevinsmaster5 Dec 1, 2023
07e7623
utilize existing translated key value
kevinsmaster5 Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/two_factor_authentication/backup_code_verification/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<% self.title = t('titles.enter_2fa_code.security_code') %>
Copy link
Copy Markdown
Contributor

@aduth aduth Dec 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was surprised this string isn't flagged as unused, but it looks like we use it for personal keys and TOTP in at least one place.

<% self.title = t('two_factor_authentication.backup_code_header_text') %>

<%= render PageHeadingComponent.new.with_content(t('two_factor_authentication.backup_code_header_text')) %>

Expand Down
2 changes: 1 addition & 1 deletion config/locales/forms/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ en:
totp_step_3: Scan this QR barcode with your app
totp_step_4: Enter the temporary code from your app
two_factor:
backup_code: Security code
backup_code: Backup code
personal_key: Personal key
try_again: Use another phone number
validation:
Expand Down
2 changes: 1 addition & 1 deletion config/locales/forms/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ es:
totp_step_3: Escanee este código de barras QR con su aplicación
totp_step_4: Ingrese el código temporal de su aplicación
two_factor:
backup_code: Código de seguridad
backup_code: Código de respaldo
personal_key: Clave personal
try_again: Use otro número de teléfono.
validation:
Expand Down
2 changes: 1 addition & 1 deletion config/locales/forms/fr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ fr:
totp_step_3: Scannez ce code-barres QR avec votre application
totp_step_4: Entrez le code temporaire de votre application
two_factor:
backup_code: Code de sécurité
backup_code: Code de sauvegarde
personal_key: Clé personnelle
try_again: Utilisez un autre numéro de téléphone
validation:
Expand Down