Skip to content

Jmax/lg 11550 read the correct pii from the session on the verify by mail enter code screen #9658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmax-gsa merged 8 commits into from
Dec 1, 2023
Merged

Jmax/lg 11550 read the correct pii from the session on the verify by mail enter code screen #9658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6556eb5
Controller spec for #index
jmax-gsa Nov 27, 2023
51fa135
Spec for create. And changelog.
jmax-gsa Nov 27, 2023
e3df850
Specs pass!
jmax-gsa Nov 29, 2023
c3d72b8
Spec cleanup.
jmax-gsa Nov 29, 2023
bdc878c
Use analytics mock properly.
jmax-gsa Nov 29, 2023
7fb1deb
Combined describe blocks.
jmax-gsa Nov 30, 2023
1634d64
Lint
jmax-gsa Nov 30, 2023
1927799
Removed &.
jmax-gsa Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions app/controllers/idv/by_mail/enter_code_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ def index
end

def pii
Pii::Cacher.new(current_user, user_session).fetch
Pii::Cacher.new(current_user, user_session).
fetch(current_user.gpo_verification_pending_profile.id)
end

def create
Expand All @@ -61,8 +62,12 @@ def create
)

if !result.success?
flash[:error] = @gpo_verify_form.errors.first.message if !rate_limiter.limited?
redirect_to idv_verify_by_mail_enter_code_url
if rate_limiter.limited?
redirect_to idv_enter_code_rate_limited_url
else
flash[:error] = @gpo_verify_form.errors.first.message if !rate_limiter.limited?
Copy link
Contributor

@JackRyan1989 JackRyan1989 Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to get to the code in this else statement if the rate_limiter is limited? Just wondering if the if !rate_limiter.limited? statement is necessary.

Copy link
Contributor Author

@jmax-gsa jmax-gsa Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because the rate limiter may have been incremented during the form submission.

redirect_to idv_verify_by_mail_enter_code_url
end
return
end

Expand Down
Loading