Skip to content

Deploy RC 332 to Production#9583

Merged
zachmargolis merged 13 commits intostages/prodfrom
stages/rc-2023-11-14
Nov 14, 2023
Merged

Deploy RC 332 to Production#9583
zachmargolis merged 13 commits intostages/prodfrom
stages/rc-2023-11-14

Conversation

@zachmargolis
Copy link
Contributor

@zachmargolis zachmargolis commented Nov 13, 2023

User-Facing Improvements

  • MFA setup: error language update for security keys or face/touch unlock (#9562)
  • Verify by Mail: Removed an alert banner no longer needed. (#9571)

Internal

  • Automated Testing: Improve accuracy of error type linter (#9569)
  • Configuration: Remove unused key_pair_generation_percent configuration key (#9566)
  • Configuration: Remove unused CSP configuration (#9573)
  • Configuration: Warn if there are configuration keys in the configuration file that are not loaded by the configuration store (#9575)
  • Documentation: Include TypeScript types in frontend naming conventions (#9574)
  • Emails: Add statement timeout since its too long a query (#9567)
  • Identity verification: Add background job to expire old GPO profiles. (#9545)
  • ServiceProvider Management: Add documentation on how to remove unused providers (#9520)
  • Development: Add dashboard integration to IDP review app (#9563)

Mitchell Henke and others added 12 commits November 8, 2023 14:39
changelog: Internal, Configuration, Remove unused key_pair_generation_percent configuration key
* Migration to add profiles.gpo_verification_expired_at

* Add Profile#deactivate_due_to_gpo_expiration

* Allow setting code_sent_at on GpoConfirmationCode factories

* Add job to expire GPO profiles that can't be verified

Not enabled yet, just putting the job in place...

changelog: Internal, Identity verification, Add background job to expire old GPO profiles.

* Add `limit:` arg to GpoExpirationJob.perform

* Remove old column from schema.rb

This column was in place locally for me after working on my old branch.

* `as_of` -> `now` in #perform

* Use a hash to hold user fixtures

* Add gpo_verification_pending_at to analytics event

Track when the user originally entered the GPO flow on the expiration analytics event.

* Add min_profile_age parameter

Allow limiting scope to profiles older than a certain age.

* Add Rake task for profile expiration backfill

Includes rollback functionality.

* Use `Profile.all` instead of `Profile.where('1=1')`

* Fix linter issues in rake file

* Use be_within to address CI failure

* Provide a little progress output during rake task
* changelog: Internal, Emails, add statement timeout since its too long a query

* fix white space and address comment
* Add how to use the DestroyUnusedProviders task

changelog: Internal, ServiceProvider Management, Add documentation on how to remove unused providers

* Remove whitespace
Old event names:

'IdV: review info visited'
'IdV: review complete'

The new event names now align with our typical scheme, based on the
controller name and the analytics_events method name:

:idv_enter_password_visited
:idv_enter_password_submitted

[skip changelog]

Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
* Enhance errors.add linter to check type argument

changelog: Internal, Automated Testing, Improve accuracy of error type linter

* Fix typo argument
changelog: Internal, Configuration, Remove unused CSP configuration
* Add dashboard container integration to IDP review app


Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
changelog: Internal, Documentation, Include TypeScript types in frontend naming conventions
* LG-11343: removes the alert banner telling users the one-time code is
now called verification code. Enough time has passed that any letters
sent with the "one-time code" language have expired.

changelog: User-Facing Improvements, Verify by Mail, Removed an alert banner no longer needed.
…re not loaded by the configuration store (#9575)

* Warn if there are configuration keys in the configuration file that are not loaded by the configuration store

changelog: Internal, Configuration, Warn if there are configuration keys in the configuration file that are not loaded by the configuration store

* Update config/initializers/unused_identity_config_keys.rb

Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

* remove unused redis config url

---------

Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Copy link
Contributor

@solipet solipet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the release notes to change f/t to face/touch

script:
- mkdir -p /kaniko/.docker
- echo ${CI_ENVIRONMENT_SLUG}
- echo $CI_ENVIRONMENT_SLUG
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just flagging it looks like this might be unintentional (not blocking)

Accidentally committed this as part of #9545

[skip changelog]

(cherry picked from commit 15f9b25)
@zachmargolis zachmargolis merged commit 7b157a3 into stages/prod Nov 14, 2023
@zachmargolis zachmargolis deleted the stages/rc-2023-11-14 branch November 14, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants