Skip to content

Remove disable_csp_unsafe_inline configuration#9573

Merged
aduth merged 1 commit intomainfrom
aduth-rm-disable-csp-unsafe-inline
Nov 9, 2023
Merged

Remove disable_csp_unsafe_inline configuration#9573
aduth merged 1 commit intomainfrom
aduth-rm-disable-csp-unsafe-inline

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Nov 9, 2023

🛠 Summary of changes

Removes the disable_csp_unsafe_inline configuration.

Why?

  • It does not appear to be used
  • It adds unnecessary risk to have a configuration responsible for controlling a security feature which requires a lot of mental gymnastics to navigate the negation and expected impact of the value (a value of "true" means "disabling" which means "not adding the exemption" which means "enforcement applies")

Slack discussion: https://gsa-tts.slack.com/archives/C0NGESUN5/p1699554919541029

📜 Testing Plan

Observe that CSP is unimpacted.

Build should pass.

changelog: Internal, Configuration, Remove unused CSP configuration
@aduth aduth merged commit bcd7046 into main Nov 9, 2023
@aduth aduth deleted the aduth-rm-disable-csp-unsafe-inline branch November 9, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants