LG-11185: Rename review events to enter password#9530
Merged
Conversation
Contributor
Author
|
Hold on merging until the corresponding devops PR is merged/deployed. |
solipet
force-pushed
the
dprice-lg-11185-rename-review-events
branch
from
d078f84 to
e3c2d08
Compare
solipet
force-pushed
the
dprice-lg-11185-rename-review-events
branch
from
e3c2d08 to
22fdc09
Compare
Old event names: 'IdV: review info visited' 'IdV: review complete' The new event names now align with our typical scheme, based on the controller name and the analytics_events method name: :idv_enter_password_visited :idv_enter_password_submitted [skip changelog] Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
solipet
force-pushed
the
dprice-lg-11185-rename-review-events
branch
from
22fdc09 to
b22a201
Compare
jmhooper
approved these changes
Nov 6, 2023
Contributor
Author
|
solipet
changed the title
Contributor
|
@R-Ornelas (Slightly belatedly) letting you know about a change to analytics. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11185
🛠 Summary of changes
Old event names:
IdV: review info visitedIdV: review completeThe new event names now align with our typical scheme, based on the controller name:
idv_enter_password_visitedidv_enter_password_submittedThis PR in the devops repo carries these event names into existing dashboards/funnels.