Merged
Conversation
* add phone_with_camera to api image upload form * changelog: Internal, Analytics, add phone_with_camera to image upload events * add phone_with_camera to image upload events in analytics spec * add phone_with_camera to api_image_upload_form_spec * add phone_with_camera to image uploads controller spec * Co-authored-by: Charles Ferguson <charles.ferguson@gsa.gov> * test phone_with_camera value logged when received when upload image * add phone_with_camera param to image upload analytics tracker methods
changelog: Internal, Review apps, Enable mailer preview in review apps
#9417) * add webauthn submitted event, edit visit event * add analytics event to controller changelog: Internal, webauthn submitted event, create webauthn submit analytics event * change webauthn submitted analytics definition * fix tests Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> * edit description of event * WIP: remove instances of MFA added webauthn event * remove added webauthn event * send `errors` hash instead of message * what if i passed `result` to `process_invalid_webauthn`? * create error hash for test * try sending the analytics on page load when error exists * remove uneeded * remove a line of unnecessary code * restore flash error * tests in support files? * remove error test from controller test * remove puts? * fix analytics test * remove from support spec * create spec file, write test for submission error * create success and failure events for webauthn_platform * add test for when submit fails * fix error hash * add platform param * remove unused error hash * move submit spec to `spec/support`, delete submit logging spec file * Empty-Commit * rough mock of tests in shared example file * fix failure event for test * remove dupe of`mock_webauthn_setup_challenge` * fix support test * remove `platform_auth_set_up_enabled` flag * Update spec/support/shared_examples/webauthn_setup.rb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * remove `sign_up_and_set_password` * test theory on setting up user * delete removed flag, set up user --------- Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
* LG-11260: resolve conflicts from main * LG-11260: change from main * LG-11260: translation updates. * LG-11260: test description. * LG-11260: resolve conflicts from main * LG-11260: rename context. * LG-11260: minor translation update. * LG-11260: inline small pieces of react elements. changelog: User-Facing Improvements, Doc Auth, Not ready experience.
* Update browserslist database changelog: Internal, Browser Support, Improve browser detection for browser support * Add Android WebView detection for BrowserSupport * Resolve yarn.lock from yarnpkg * Add Opera Mobile detection logic * Adjust spec context for Opera Mobile See: https://github.com/18F/identity-idp/pull/9557/files#r1385593619
* Add documentation for sample applications changelog: Internal, Documentation, Add documentation for sample applications * Add local SAML test route instructions Co-Authored-By: Charley Ferguson <6818839+charleyf@users.noreply.github.com> --------- Co-authored-by: Charley Ferguson <6818839+charleyf@users.noreply.github.com>
* changelog: Internal, Authentication, Disposable emails database loaded * fix lint * delete load * email db script * move loading email data to class * rubocop * domain pull * fix rake and application.rb * use script in csv format * make sure header is true * update schema * remove schema change that wasnt needed * update rake to deal with text file
* button continue -> submit * place text under verify info * add changelog changelog: User-Facing Improvements, IdV Verify Info, add text clarifying purpose of verify info screen * spacing * fix tests to use submit instead of continue * fix verify_info_step_spec * fix more submit button errors in specs * use complete_verify_step instead of click method * ipp verify info step spec fix
zachmargolis
approved these changes
Nov 8, 2023
Comment on lines
+480
to
+485
| case params[:phone_with_camera] | ||
| when 'true' | ||
| true | ||
| when 'false' | ||
| false | ||
| end |
Contributor
There was a problem hiding this comment.
(not blocking) I missed it in the original PR, but my favorite trick to coerce strings to bools is:
Suggested change
| case params[:phone_with_camera] | |
| when 'true' | |
| true | |
| when 'false' | |
| false | |
| end | |
| params[:phone_with_camera].to_s == 'true' |
| # @param [String] back_image_fingerprint Fingerprint of back image data | ||
| # @param [String] getting_started_ab_test_bucket Which initial IdV screen the user saw | ||
| # @param [String] phone_question_ab_test_bucket Prompt user with phone question before doc auth | ||
| # @param [String] phone_with_camera the result of the phone question a/b test |
Contributor
There was a problem hiding this comment.
(not blocking) also missed in the original PR, but this is a boolean right?
Suggested change
| # @param [String] phone_with_camera the result of the phone question a/b test | |
| # @param [Boolean] phone_with_camera the result of the phone question a/b test |
soniaconnolly
approved these changes
Nov 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Internal