-
Notifications
You must be signed in to change notification settings - Fork 166
Deploy RC 331 to Production #9565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1db5d83
LG-11427 add phone with camera to image upload (#9537)
amirbey 4743e8e
Enable mailer previews in sandbox review apps (#9542)
zachmargolis f2c4792
Bring back scheduled IDV maintenance (LG-11306) (#9552)
zachmargolis df26d60
LG-11165: Create separate "submitted" event for WebAuthn registration…
jmdembe 8cc4eb6
LG-11260: docauth not ready (#9506)
dawei-nava 66dfd14
Support Android WebView for browser support detection (#9557)
aduth 90ee201
Add documentation for sample applications (#9558)
aduth e68ec07
LG-111208: disposable email database (#9440)
mdiarra3 e54b04e
LG-11383 Update Verify Info Screen (#9556)
theabrad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 53 additions & 0 deletions
53
app/javascript/packages/document-capture/components/document-capture-not-ready.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| import { Button } from '@18f/identity-components'; | ||
| import { useI18n } from '@18f/identity-react-i18n'; | ||
| import { useContext } from 'react'; | ||
| import FlowContext from '@18f/identity-verify-flow/context/flow-context'; | ||
| import { addSearchParams, forceRedirect, Navigate } from '@18f/identity-url'; | ||
| import { getConfigValue } from '@18f/identity-config'; | ||
| import AnalyticsContext from '../context/analytics'; | ||
| import { ServiceProviderContext } from '../context'; | ||
|
|
||
| export interface DocumentCaptureNotReadyProps { | ||
| navigate?: Navigate; | ||
| } | ||
|
|
||
| function DocumentCaptureNotReady({ navigate }: DocumentCaptureNotReadyProps) { | ||
| const { t } = useI18n(); | ||
| const { trackEvent } = useContext(AnalyticsContext); | ||
| const { currentStep } = useContext(FlowContext); | ||
| const { name: spName, failureToProofURL } = useContext(ServiceProviderContext); | ||
| const appName = getConfigValue('appName'); | ||
| const handleExit = () => { | ||
| trackEvent('IdV: docauth not ready link clicked'); | ||
| forceRedirect( | ||
| addSearchParams(spName ? failureToProofURL : '/account', { | ||
| step: currentStep, | ||
| location: 'not_ready', | ||
| }), | ||
| navigate, | ||
| ); | ||
| }; | ||
|
|
||
| return ( | ||
| <> | ||
| <h2 className="h3">{t('doc_auth.not_ready.header')}</h2> | ||
| <p> | ||
| {spName | ||
| ? t('doc_auth.not_ready.content_sp', { | ||
| sp_name: spName, | ||
| app_name: appName, | ||
| }) | ||
| : t('doc_auth.not_ready.content_nosp', { | ||
| app_name: appName, | ||
| })} | ||
| </p> | ||
| <Button isUnstyled className="margin-top-1" onClick={handleExit}> | ||
| {spName | ||
| ? t('doc_auth.not_ready.button_sp', { app_name: appName, sp_name: spName }) | ||
| : t('doc_auth.not_ready.button_nosp')} | ||
| </Button> | ||
| </> | ||
| ); | ||
| } | ||
|
|
||
| export default DocumentCaptureNotReady; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
app/javascript/packages/document-capture/context/feature-flag.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import { createContext } from 'react'; | ||
|
|
||
| export interface FeatureFlagContextProps { | ||
| /** | ||
| * Specify whether to show the not-ready section on doc capture screen. | ||
| * Populated from backend configuration | ||
| */ | ||
| notReadySectionEnabled: boolean; | ||
| } | ||
|
|
||
| const FeatureFlagContext = createContext<FeatureFlagContextProps>({ | ||
| notReadySectionEnabled: false, | ||
| }); | ||
|
|
||
| FeatureFlagContext.displayName = 'FeatureFlagContext'; | ||
|
|
||
| export default FeatureFlagContext; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| class DisposableDomain < ApplicationRecord | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -976,6 +976,7 @@ def idv_doc_auth_ssn_visited(**extra) | |||||
| # @param [String] back_image_fingerprint Fingerprint of back image data | ||||||
| # @param [String] getting_started_ab_test_bucket Which initial IdV screen the user saw | ||||||
| # @param [String] phone_question_ab_test_bucket Prompt user with phone question before doc auth | ||||||
| # @param [String] phone_with_camera the result of the phone question a/b test | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (not blocking) also missed in the original PR, but this is a boolean right?
Suggested change
|
||||||
| # The document capture image uploaded was locally validated during the IDV process | ||||||
| def idv_doc_auth_submitted_image_upload_form( | ||||||
| success:, | ||||||
|
|
@@ -988,6 +989,7 @@ def idv_doc_auth_submitted_image_upload_form( | |||||
| back_image_fingerprint: nil, | ||||||
| getting_started_ab_test_bucket: nil, | ||||||
| phone_question_ab_test_bucket: nil, | ||||||
| phone_with_camera: nil, | ||||||
| **extra | ||||||
| ) | ||||||
| track_event( | ||||||
|
|
@@ -1002,6 +1004,7 @@ def idv_doc_auth_submitted_image_upload_form( | |||||
| back_image_fingerprint: back_image_fingerprint, | ||||||
| getting_started_ab_test_bucket: getting_started_ab_test_bucket, | ||||||
| phone_question_ab_test_bucket: phone_question_ab_test_bucket, | ||||||
| phone_with_camera: phone_with_camera, | ||||||
| **extra, | ||||||
| ) | ||||||
| end | ||||||
|
|
@@ -1023,6 +1026,7 @@ def idv_doc_auth_submitted_image_upload_form( | |||||
| # @param [String] back_image_fingerprint Fingerprint of back image data | ||||||
| # @param [String] getting_started_ab_test_bucket Which initial IdV screen the user saw | ||||||
| # @param [String] phone_question_ab_test_bucket Prompt user with phone question before doc auth | ||||||
| # @param [String] phone_with_camera the result of the phone question a/b test | ||||||
| # The document capture image was uploaded to vendor during the IDV process | ||||||
| def idv_doc_auth_submitted_image_upload_vendor( | ||||||
| success:, | ||||||
|
|
@@ -1041,6 +1045,7 @@ def idv_doc_auth_submitted_image_upload_vendor( | |||||
| back_image_fingerprint: nil, | ||||||
| getting_started_ab_test_bucket: nil, | ||||||
| phone_question_ab_test_bucket: nil, | ||||||
| phone_with_camera: nil, | ||||||
| **extra | ||||||
| ) | ||||||
| track_event( | ||||||
|
|
@@ -1062,6 +1067,7 @@ def idv_doc_auth_submitted_image_upload_vendor( | |||||
| back_image_fingerprint: back_image_fingerprint, | ||||||
| getting_started_ab_test_bucket: getting_started_ab_test_bucket, | ||||||
| phone_question_ab_test_bucket: phone_question_ab_test_bucket, | ||||||
| phone_with_camera: phone_with_camera, | ||||||
| **extra, | ||||||
| ) | ||||||
| end | ||||||
|
|
@@ -3181,24 +3187,6 @@ def multi_factor_auth_added_totp(enabled_mfa_methods_count:, in_account_creation | |||||
| ) | ||||||
| end | ||||||
|
|
||||||
| # Tracks when the user has added the MFA method webauthn to their account | ||||||
| # @param [Boolean] platform_authenticator indicates if webauthn_platform was used | ||||||
| # @param [Integer] enabled_mfa_methods_count number of registered mfa methods for the user | ||||||
| def multi_factor_auth_added_webauthn( | ||||||
| platform_authenticator:, | ||||||
| enabled_mfa_methods_count:, **extra | ||||||
| ) | ||||||
| track_event( | ||||||
| 'Multi-Factor Authentication: Added webauthn', | ||||||
| { | ||||||
| method_name: :webauthn, | ||||||
| platform_authenticator: platform_authenticator, | ||||||
| enabled_mfa_methods_count: enabled_mfa_methods_count, | ||||||
| **extra, | ||||||
| }.compact, | ||||||
| ) | ||||||
| end | ||||||
|
|
||||||
| # A user has downloaded their backup codes | ||||||
| def multi_factor_auth_backup_code_download | ||||||
| track_event('Multi-Factor Authentication: download backup code') | ||||||
|
|
@@ -4804,18 +4792,27 @@ def webauthn_deleted(success:, mfa_method_counts:, pii_like_keypaths:, **extra) | |||||
| end | ||||||
|
|
||||||
| # @param [Hash] platform_authenticator | ||||||
| # @param [Hash] errors | ||||||
| # @param [Integer] enabled_mfa_methods_count | ||||||
| # @param [Boolean] success | ||||||
| # @param [Hash, nil] errors | ||||||
| # Tracks whether or not Webauthn setup was successful | ||||||
| def webauthn_setup_submitted(platform_authenticator:, success:, errors: nil, **extra) | ||||||
| track_event( | ||||||
| :webauthn_setup_submitted, | ||||||
| platform_authenticator: platform_authenticator, | ||||||
| success: success, | ||||||
| errors: errors, | ||||||
| **extra, | ||||||
| ) | ||||||
| end | ||||||
|
|
||||||
| # @param [Hash] platform_authenticator | ||||||
| # @param [Integer] enabled_mfa_methods_count | ||||||
| # Tracks when WebAuthn setup is visited | ||||||
| def webauthn_setup_visit(platform_authenticator:, errors:, enabled_mfa_methods_count:, success:, | ||||||
| **extra) | ||||||
| def webauthn_setup_visit(platform_authenticator:, enabled_mfa_methods_count:, **extra) | ||||||
| track_event( | ||||||
| 'WebAuthn Setup Visited', | ||||||
| platform_authenticator: platform_authenticator, | ||||||
| errors: errors, | ||||||
| enabled_mfa_methods_count: enabled_mfa_methods_count, | ||||||
| success: success, | ||||||
| **extra, | ||||||
| ) | ||||||
| end | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(not blocking) I missed it in the original PR, but my favorite trick to coerce strings to bools is: