LG-11165: Create separate "submitted" event for WebAuthn registrations#9417
LG-11165: Create separate "submitted" event for WebAuthn registrations#9417
Conversation
changelog: Internal, webauthn submitted event, create webauthn submit analytics event
|
I just tested this by trying to add a Face/Touch credential from my account dashboard and cancelling when prompted for my credential, and I didn't see a submitted event logged. I think the problem is we don't actually submit the form when handling frontend errors, we just reload with a new query parameter, which probably explains why we were handling errors in the Could you see what we'd need to do to handle those errors? Arguably those are the ones we care about the most, so it'd be important to capture, and I think we should have test coverage for them as well. |
kevinsmaster5
left a comment
There was a problem hiding this comment.
Looks good to me.
I was able to validate that this comment: #9417 (comment) is no longer an issue. Cancelling when prompted will log the error now.
aduth
left a comment
There was a problem hiding this comment.
LGTM 👍 Left a couple minor nitpicks.
Per the ticket, can we also make sure to have the relevant dashboards ready for the new event before this goes live in production?
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
🎫 Ticket
LG-11165: Create separate "submitted" event for WebAuthn registrations
🛠 Summary of changes
This ticket creates and modifies events associated with Webauthn Setup.
Webauthn Setup Visited: Now tracks page visits only;Webauthn Setup Submitted: Tracks successful submission and any error message