Skip to content

LG-11377 Add Selfie UI#9580

Merged
charleyf merged 47 commits intomainfrom
charley/selfie-try-three
Nov 28, 2023
Merged

LG-11377 Add Selfie UI#9580
charleyf merged 47 commits intomainfrom
charley/selfie-try-three

Conversation

@charleyf
Copy link
Contributor

@charleyf charleyf commented Nov 13, 2023

🎫 Ticket

https://cm-jira.usa.gov/browse/LG-11377

🛠 Summary of changes

This is PR 3 of 3 that will meet the ACs of LG-11377

  1. #9536 Add the feature flag
  2. #9546 Make AcuantPassiveLiveness available in the FE (loading the script).
  3. #9580 (this PR) Add the selfie UI.

This PR uses the Acuant SDK to capture a selfie on the document upload page in the docauth javascript app. All work in this PR should be behind a featureflag. To see it locally set this in application.yml doc_auth_selfie_capture: '{"enabled":true}'

This is a replacement for the work in #9553, the comments there are still relevant. Also see this Slack thread for context.

There are two tickets that were generated during this PR:

  • LG-11631, adding analytics for the selfie capture.
  • LG-11632, investigating an edge case/bug.

📜 Testing Plan

There are two things that should be tested.

  1. That this work is in fact behind the featureflag.
    • A developer needs to do this, by turning the featureflag off/on and making sure the selfie capture field on the doc upload page appears and disappears as expected.
  2. That this work functions correctly on iPhones and Androids. Basically we want to make sure that the basics of capturing a selfie work correctly.
    • Log in and go to the document authentication page (with the featureflag on)
    • Upload the front/back of the id and a selfie of yourself.
    • Click submit.

👀 Screenshots

Screenshots here, but also see this slack thread for demos and updates.

Screenshots Screenshot 2023-11-17 at 11 25 55
11-13-2023-selfie-demo.MP4

@charleyf charleyf changed the title Charley/selfie try three LG-11377 Add Selfie UI Nov 13, 2023
)}
</AcuantCamera>
)}
{isCapturingEnvironment && selfieCapture && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been reading isCapturingEnvironment as "The full screen overlay is open, providing the correct environment for capturing an image from the Acuant SDK".

I might be affected by Monday brain fuzziness, but I thought this, too. I wonder if part of why we thought this was because in our previous work with this code, whenever the full screen overlay was open and providing the correct environment for capturing an image from the Acuant SDK, the user would also be using the back cam on phones? The conditions overlapped for id image capture in a way that they don't overlap for selfie capture.

(I agree with Dawei that it would be good to have comments/documentation about this.)

charleyf and others added 3 commits November 22, 2023 12:23
Co-authored-by: Brittany Greaner <35475380+night-jellyfish@users.noreply.github.com>
@eileen-nava eileen-nava self-requested a review November 22, 2023 21:35
Copy link
Contributor

@eileen-nava eileen-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this before the build passes because Charley and I looked at the test fix in a meeting, and I know it will work.

Great work! 🥳 🦃 🥳 🦃

Copy link
Contributor

@dawei-nava dawei-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested together with backend change, the happy path works as expected.

@charleyf charleyf merged commit e035d5b into main Nov 28, 2023
@charleyf charleyf deleted the charley/selfie-try-three branch November 28, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants