Conversation
This reverts commit 3d3741e.
app/javascript/packages/document-capture/components/acuant-capture.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
app/javascript/packages/document-capture/components/acuant-selfie-capture-canvas.jsx
Show resolved
Hide resolved
| )} | ||
| </AcuantCamera> | ||
| )} | ||
| {isCapturingEnvironment && selfieCapture && ( |
There was a problem hiding this comment.
I've been reading
isCapturingEnvironmentas "The full screen overlay is open, providing the correct environment for capturing an image from the Acuant SDK".
I might be affected by Monday brain fuzziness, but I thought this, too. I wonder if part of why we thought this was because in our previous work with this code, whenever the full screen overlay was open and providing the correct environment for capturing an image from the Acuant SDK, the user would also be using the back cam on phones? The conditions overlapped for id image capture in a way that they don't overlap for selfie capture.
(I agree with Dawei that it would be good to have comments/documentation about this.)
spec/javascript/packages/document-capture/components/document-capture-spec.jsx
Show resolved
Hide resolved
app/javascript/packages/document-capture/components/document-capture-review-issues.tsx
Show resolved
Hide resolved
app/javascript/packages/document-capture/components/acuant-capture.tsx
Outdated
Show resolved
Hide resolved
app/javascript/packages/document-capture/components/acuant-capture.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Brittany Greaner <35475380+night-jellyfish@users.noreply.github.com>
eileen-nava
left a comment
There was a problem hiding this comment.
I am approving this before the build passes because Charley and I looked at the test fix in a meeting, and I know it will work.
Great work! 🥳 🦃 🥳 🦃
dawei-nava
left a comment
There was a problem hiding this comment.
Tested together with backend change, the happy path works as expected.
🎫 Ticket
https://cm-jira.usa.gov/browse/LG-11377
🛠 Summary of changes
This is PR 3 of 3 that will meet the ACs of LG-11377
AcuantPassiveLivenessavailable in the FE (loading the script).This PR uses the Acuant SDK to capture a selfie on the document upload page in the docauth javascript app. All work in this PR should be behind a featureflag. To see it locally set this in application.yml
doc_auth_selfie_capture: '{"enabled":true}'This is a replacement for the work in #9553, the comments there are still relevant. Also see this Slack thread for context.
There are two tickets that were generated during this PR:
📜 Testing Plan
There are two things that should be tested.
👀 Screenshots
Screenshots here, but also see this slack thread for demos and updates.
Screenshots
11-13-2023-selfie-demo.MP4