Skip to content

Fix pinpoint script parsing #9262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachmargolis merged 1 commit into from
Sep 25, 2023
Merged

Fix pinpoint script parsing #9262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/pinpoint_supported_countries.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ def sms_support

CountrySupport.new(
iso_code: iso_code,
name: trim_spaces(sms_config['Country or region']),
name: trim_spaces_digits(sms_config['Country or region']),
supports_sms: supports_sms,
)
end
Expand Down Expand Up @@ -159,6 +159,10 @@ def trim_spaces(str)
str.gsub(/\s{2,}/, ' ').gsub(/\s+$/, '')
end

def trim_spaces_digits(str)
Copy link
Copy Markdown
Contributor

@soniaconnolly soniaconnolly Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment explaining why this is here?

Suggested change
def trim_spaces_digits(str)
# Remove trailing footnote numbers from country names
def trim_spaces_digits(str)

Copy link
Copy Markdown
Contributor Author

@zachmargolis zachmargolis Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a bunch of trimming code and other footnotes in other columns (and in the specs) so I think it'll be ok without

trim_spaces(str).gsub(/\d+$/, '')
end

def digits_only?(str)
str.to_i.to_s == str
end
Expand Down
2 changes: 1 addition & 1 deletion spec/lib/pinpoint_supported_countries_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
</td>
</tr>
<tr>
<td>Argentina</td>
<td>Argentina<sup><a href="#sms-support-note-1">2</a></sup></td>
<td>AR</td>
<td></td>
<td>Yes</td>
Expand Down