Skip to content

10787: Combine then extract FullAddressSearch component#9179

Merged
allthesignals merged 3 commits intomainfrom
10787-fas-combine-2
Sep 11, 2023
Merged

10787: Combine then extract FullAddressSearch component#9179
allthesignals merged 3 commits intomainfrom
10787-fas-combine-2

Conversation

@allthesignals
Copy link
Contributor

🎫 Ticket

🛠 Summary of changes

This PR does two things:

  1. Moves the IPP results components into the FullAddressSearch component.
  2. Renames then moves FullAddressSearchInput into a separate component.

This PR is another intermediary step before fully moving this component into the address-search pacakge.

📜 Testing Plan

  • This is a refactor, there are no user-facing changes.

@allthesignals allthesignals marked this pull request as ready for review September 8, 2023 19:31
@gina-yamada gina-yamada self-requested a review September 11, 2023 14:36
Copy link
Contributor

@gina-yamada gina-yamada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Started server, working as expected. Walked through code changes/moves, LGTM

@allthesignals allthesignals merged commit 700fbee into main Sep 11, 2023
@allthesignals allthesignals deleted the 10787-fas-combine-2 branch September 11, 2023 17:58
@aduth aduth mentioned this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants